- Notifications
You must be signed in to change notification settings - Fork 38
[CM-2442] File Titles and Comments Update to KMChat from ALK | iOS SDK (Part - 2) #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedFailed to post review comments. Configuration used: CodeRabbit UI 📒 Files selected for processing (22)
🧰 Additional context used🧬 Code Graph Analysis (2)Example/Tests/Mocks/ConversationDetailMock.swift (1)
Sources/Kommunicate/Classes/KMBotService.swift (1)
🪛 SwiftLint (0.57.0)Example/Tests/KMConversationViewControllerTests.swift[Warning] 21-21: Initializers declared in compiler protocol ExpressibleByIntegerLiteral shouldn't be called directly (compiler_protocol_init) Sources/Kommunicate/Classes/Kommunicate.swift[Error] 1324-1324: Force casts should be avoided (force_cast) ⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (20)
WalkthroughThis change refactors the codebase to replace legacy AL/ALK-prefixed classes, protocols, and services with their KMCore/KMChat-prefixed counterparts throughout the Kommunicate SDK. The update affects controllers, models, services, extensions, tests, and configuration types, aligning the code with a new core architecture. No significant control flow or logic changes are introduced. Changes
Sequence Diagram(s)sequenceDiagram participant User participant KMConversationListViewController participant KMChatConversationViewModel participant KMConversationViewController participant KMCoreChannelService participant KMCoreMessageService User->>KMConversationListViewController: Selects a conversation KMConversationListViewController->>KMChatConversationViewModel: Prepare view model KMConversationListViewController->>KMConversationViewController: Push with new view model KMConversationViewController->>KMCoreChannelService: Fetch channel info KMConversationViewController->>KMCoreMessageService: Sync messages KMConversationViewController->>User: Display conversation UI Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
Summary
Testing Branches
KM_ChatUI_Branch :
CM-2442
KM_Core_Branch:
dev
Summary by CodeRabbit