Skip to content

Conversation

@franknoirot
Copy link
Contributor

Another tiny appearance tweak PR. A few mono font points are left, mostly for numbers which look better in monospace.

@vercel
Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 18, 2025 2:01am
@qa-wolf
Copy link

qa-wolf bot commented Apr 17, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@franknoirot franknoirot requested a review from a team April 17, 2025 16:00
Copy link
Contributor

@lee-at-zoo-corp lee-at-zoo-corp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't visually look but code-wise looks good

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (bd4bad0) to head (00b779a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #6373 +/- ## ========================================== + Coverage 85.05% 85.06% +0.01%  ========================================== Files 108 108 Lines 46338 46338 ========================================== + Hits 39411 39417 +6  + Misses 6927 6921 -6 
Flag Coverage Δ
rust 85.06% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
A few mono font points are left, mostly for numbers which look better in monospace.
@franknoirot franknoirot force-pushed the franknoirot/adhoc/appearance-tweaks-modeling-view branch from 55883a7 to ea330c3 Compare April 17, 2025 18:19
@franknoirot franknoirot enabled auto-merge (squash) April 17, 2025 18:20
Comment on lines -631 to -632
fill-rule="evenodd"
clip-rule="evenodd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops that was me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah all good! @lee-at-zoo-corp pointed it out to me

@franknoirot franknoirot merged commit 03c4121 into main Apr 18, 2025
37 of 40 checks passed
@franknoirot franknoirot deleted the franknoirot/adhoc/appearance-tweaks-modeling-view branch April 18, 2025 18:11
franknoirot added a commit that referenced this pull request Apr 18, 2025
franknoirot added a commit that referenced this pull request Apr 18, 2025
Revert "Remove all use of bold mono font (#6373)" This reverts commit 03c4121.
@franknoirot franknoirot restored the franknoirot/adhoc/appearance-tweaks-modeling-view branch April 21, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants