Joycons and Pro Controller Rumble #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| It may also not be necessary if all changes are accepted. It may also be that if one joycon is connected, then it might make sense to create an option that will average the vibration between the two controllers and send it to one (in the case of simple vibration) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This allows Nintendo controllers to rumble. In my application, which uses separate code instead of JoyShockLibrary, it works correctly. For some reason, this functionality does not work when integrated into the library, but I believe it could be useful for further development of rumble support.
The code was tested in wireless mode with controllers compatible with the Pro Controller and Joy-Cons. Unfortunately, it was not possible to test on original controllers, so testing was carried out only on compatible controllers.
Thank you for your library!