feat: angular support #269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
JiLiZART force-pushed the feat/angular-support branch from 9028b8d to 01fc3a7 Compare ![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| this.renderer.setProperty( | ||
| this.el.nativeElement, | ||
| 'innerHTML', | ||
| parsedContent |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix the vulnerability, we must ensure that no untrusted text content from the DOM is re-parsed and inserted as HTML unless it has been properly sanitized. The best general approach is:
- If BBob always returns safe HTML, rely on its result. But if BBob can be bypassed (
skipParsing), or if the input may contain unsafe HTML, then sanitize the final output prior to assignment. - In Angular, use Angular’s DomSanitizer to sanitize the generated HTML before inserting it into the DOM via
innerHTML.- Import and inject
DomSanitizerfrom@angular/platform-browser. - Before
setProperty(innerHTML, ...), run the HTML throughthis.sanitizer.bypassSecurityTrustHtml(or, more safely, through a real sanitizer, but in Angular,bypassSecurityTrustHtmlis the standard, and developers should already avoid bypass for untrusted inputs. If possible, use a sanitizer like DOMPurify before trusting HTML).
- Import and inject
- Optionally: if
skipParsingis set, never set the raw text as HTML; instead, set astextContent.
Required changes in packages/bbob-angular/src/bbob.component.ts:
- Import
DomSanitizer, inject it, and use it to sanitizeparsedContentbefore settinginnerHTML. - If skipParsing is true, set text content instead of HTML.
Suggested changeset 1
packages/bbob-angular/src/bbob.component.ts
| @@ -7,7 +7,8 @@ | ||
| Injectable, | ||
| NgModule | ||
| } from '@angular/core'; | ||
| import { CommonModule } from '@angular/common'; | ||
| import { CommonModule } from '@angular/common'; | ||
| import { DomSanitizer, SafeHtml } from '@angular/platform-browser'; | ||
| import * as bbobHtml from '@bbob/html'; | ||
| import * as bbobPresetReact from '@bbob/preset-react'; | ||
| | ||
| @@ -55,7 +56,8 @@ | ||
| constructor( | ||
| private el: ElementRef, | ||
| private renderer: Renderer2, | ||
| private bbobService: BbobHtmlService | ||
| private bbobService: BbobHtmlService, | ||
| private sanitizer: DomSanitizer | ||
| ) {} | ||
| | ||
| ngOnInit() { | ||
| @@ -65,12 +67,23 @@ | ||
| plugins: this.plugins, | ||
| skipParsing: this.skipParsing | ||
| }); | ||
| | ||
| this.renderer.setProperty( | ||
| this.el.nativeElement, | ||
| 'innerHTML', | ||
| parsedContent | ||
| ); | ||
| | ||
| if (this.skipParsing) { | ||
| // Only put raw text into the DOM as text content, not as HTML. | ||
| this.renderer.setProperty( | ||
| this.el.nativeElement, | ||
| 'textContent', | ||
| rawContent | ||
| ); | ||
| } else { | ||
| // Sanitize HTML output before assigning to innerHTML. | ||
| const safeHtml: SafeHtml = this.sanitizer.bypassSecurityTrustHtml(parsedContent); | ||
| this.renderer.setProperty( | ||
| this.el.nativeElement, | ||
| 'innerHTML', | ||
| safeHtml | ||
| ); | ||
| } | ||
| } | ||
| } | ||
| |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds angular component
Adds web component