Skip to content

Conversation

LoayGhreeb
Copy link
Member

@LoayGhreeb LoayGhreeb commented Jun 26, 2024

Some improvements to the document viewer and search results tab

  • Clicking on the page number to open the document viewer, it was displaying the first linked file of the selected entry instead of the correct file. Also without custom CSS.

  • "Open file" was open all linked files to the entry.
    image

  • Added validation to the next and previous page buttons in the document viewer to disable them on the first and last pages.

  • Close the document viewer when the selected entry does not have any linked files.

  • Avoid opening multiple document viewers.

  • Selecting multiple entries will add all linked files of the selected entries to the list of files.
    image

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
@Siedlerchr
Copy link
Member

Codewise lgtm so far. Cannot test right now but hope you did 😅

@Siedlerchr Siedlerchr enabled auto-merge June 26, 2024 15:36
@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 26, 2024
Merged via the queue into JabRef:main with commit 1c0e4ec Jun 26, 2024
@LoayGhreeb LoayGhreeb deleted the Improve-documentViewer branch June 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants