Skip to content

[feat] Support for JSON_TABLE #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[feat] Support for JSON_TABLE #2328

wants to merge 3 commits into from

Conversation

ANeumann82
Copy link
Contributor

No description provided.

manticore-projects
manticore-projects requested changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@manticore-projects manticore-projects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and I do appreciate your effort and dedication. Thank you much!
A few small concerns though, nothing severe just the normal German nit-picking.

Kudos and cheers!
src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
| <#TYPE_REAL: "REAL" | "FLOAT4" | "FLOAT">
| <#TYPE_DOUBLE: "DOUBLE" | "PRECISION" | "FLOAT8" | "FLOAT64">
| <#TYPE_VARCHAR: "NVARCHAR" | "VARCHAR" | "NCHAR" | <K_CHAR> | "BPCHAR" | "TEXT" | "STRING" | <K_CHARACTER> | "VARYING">
| <#TYPE_VARCHAR2: <K_VARCHAR2>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should got to TYPE_VARCHAR since we try to establish a reasonable grouping please.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was left over from me figuring it out
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem. When I move this into the TYPE_VARCHAR, the generated TokenManager gets a code too large. I guess we're reaching the limits of JavaCC again...

I'll have to look into why exactly this happens, but I've not applied this change yet in my last commit.
@ANeumann82
Copy link
Contributor Author

Great work and I do appreciate your effort and dedication. Thank you much! A few small concerns though, nothing severe just the normal German nit-picking.

Kudos and cheers!

Keep the nit-picking coming :) There's still some features missing before I'll consider this PR ready for merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ANeumann82 @manticore-projects