Add new fields and loader #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Satyam1203 commented Oct 4, 2020
Satyam1203 commented - Added DOB and Phone field (Issue - Ui Improvements for the App #1 )
- Added loading indicator as a proper component ( Issue - Add loading indicator on initial load #3 )
- Exact centered the image (Instead of margin-left)
- Used grid to properly align fields
- Changed h1 -> h2 to make country and phone appear on one line.
- Corrected the key attribute (was wrongly assigned an undefined value earlier)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.