Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
revert a change that was made #73
On windows with numpy-2.x.x, we have
where
numpy.dtype("q") = dtype('int64')
so in #73 an "if condition" fors = 'q'
was added toget_args
function intest_basic.py
. The existing "if condition" fors = 'l'
should not change since with numpy-1.26.x on Windows we havewhere
numpy.dtype("l") = dtype('int32')
.While on Linux for both numpy-1.26.x and numpy-2.x.x
where
numpy.dtype("l") = dtype('int64')
.