Skip to content

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented May 22, 2025

revert a change that was made #73

On windows with numpy-2.x.x, we have

>>> numpy.ldexp.types ['ei->e', 'fi->f', 'eq->e', 'fq->f', 'di->d', 'dq->d', 'gi->g', 'gq->g'] 

where numpy.dtype("q") = dtype('int64') so in #73 an "if condition" for s = 'q' was added to get_args function in test_basic.py. The existing "if condition" for s = 'l' should not change since with numpy-1.26.x on Windows we have

>>> numpy.ldexp.types ['ei->e', 'fi->f', 'el->e', 'fl->f', 'di->d', 'dl->d', 'gi->g', 'gl->g'] 

where numpy.dtype("l") = dtype('int32').

While on Linux for both numpy-1.26.x and numpy-2.x.x

>>> numpy.ldexp.types ['ei->e', 'fi->f', 'el->e', 'fl->f', 'di->d', 'dl->d', 'gi->g', 'gl->g'] 

where numpy.dtype("l") = dtype('int64').

@vtavana vtavana marked this pull request as ready for review May 22, 2025 21:25
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle, glad it was caught, LGTM

@vtavana vtavana merged commit 5a03441 into main May 23, 2025
32 checks passed
@vtavana vtavana deleted the update-tests branch May 23, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants