[MOB-12026] Fix TS Compile Error #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TheBuggedYRN suggested changes Feb 27, 2023
DavidMina96 force-pushed the fix/ts-compile-error branch from b498bf6 to 9e26721 Compare TheBuggedYRN approved these changes Feb 27, 2023
DavidMina96 force-pushed the fix/ts-compile-error branch from 9e26721 to 4315fc4 Compare HeshamMegid pushed a commit that referenced this pull request Mar 1, 2023
Remove the test dir from being included in tsconfig.json and add a separate tsconfig.test.json for the tests configuration, preserving the old dist structure and providing the required files for the tests to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of the change
Problem
A TS compile error started to arise on
v11.9.0due to thedistdir having a different structure than the entry points provided inpackage.json. In particular, adding thetestdir intsconfig.jsonincludeproperty is the root cause of the change. This was done during the unit tests migration to TS to resolve an error related to the declaration file for modulexhr2, which is inside thetestdir.Solution
Remove the
testdir from being included and add a separatetsconfig.test.jsonfor the tests configuration, which would preserve the olddiststructure and provide the required files for the tests to run.Note:
Changelog formatting according to the new guidelines will be done entirely in a separate PR.
Type of change
Related issues
Checklists
Development
Code review