[MOB-7935] Favor namespaced import of React/RCTConvert.h

[theohdv]

Description of the change

Could not upgrade to expo 44 because iOS build was failing.

As explained here: expo/expo#15622 (comment)

Old style imports are not supported anymore from expo 44.

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

• Lint rules pass locally
• The code changed/added as part of this pull request has been covered with tests

Code review

• This pull request has a descriptive title and information useful to a reviewer
• Issue from task tracker has a link to this pull request

[justblender]

@theohdv, this seems to be related to my issue #660.

To avoid breaking compatibility with older versions of React Native, I propose to just inverse the condition in RCTConvert+InstabugEnums.h:

-#if __has_include("RCTConvert.h") - #import "RCTConvert.h" -#else +#if __has_include("React/RCTConvert.h") #import <React/RCTConvert.h> +#else + #import "RCTConvert.h" #endif

Although as far as "breaking compatibility with older versions" goes, move to namespaced includes happened in RN 0.40.0, which is quite an outdated version today. Still, it's good to have a backup in any case.

[theohdv]

@justblender Thanks for the suggestion !
Yes would be better like that, did you try your solution with expo 44 ?

[justblender]

Yes would be better like that, did you try your solution with expo 44 ?

@theohdv, yes. I'm using expo@44.0.5 on a bare workflow RN 0.67.0 project and it compiles just fine after applying that change via patch-package.

[theohdv]

@justblender thanks a lot, just made the changes

[codecov]

Codecov Report

Merging #663 (6b3a65b) into master (dd6075a) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #663 +/- ## ======================================= Coverage 88.23% 88.23% ======================================= Files 24 24 Lines 459 459 Branches 91 91 ======================================= Hits 405 405 Misses 46 46 Partials 8 8 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6075a...6b3a65b. Read the comment docs.