Skip to content

feat(ios): add native-side init API for startup crashes #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 14, 2023
Merged

feat(ios): add native-side init API for startup crashes #1056

merged 9 commits into from
Nov 14, 2023

Conversation

@a7medev
Copy link
Contributor

@a7medev a7medev commented Nov 12, 2023 •
edited
Loading

Description of the change

Provide a native iOS-side init API that allows starting the SDK early (and before the JavaScript has started) in the app lifecycle allowing them to capture early crashes in their app.

  1. Added [RNInstabug initWithToken:invocationEvents:] and [RNInstabug initWithToken:invocationEvents:debugLogsLevel:] APIs.
  2. Refactored the native module method for Instabug.init to use RNInstabug internally.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13246

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request
@a7medev a7medev marked this pull request as draft November 12, 2023 21:40
@a7medev a7medev self-assigned this Nov 12, 2023
@InstabugCI
Copy link
Collaborator

InstabugCI commented Nov 12, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 95.8% ✅
Android 50.3% ✅
iOS 40.6% ✅

Generated by 🚫 dangerJS against 8a3ecc2

@a7medev a7medev changed the base branch from master to dev November 13, 2023 09:47
@a7medev a7medev marked this pull request as ready for review November 13, 2023 11:19
abdelhamid-f-nasser
abdelhamid-f-nasser approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job as always 🟢 👌
@a7medev a7medev merged commit 112dd17 into dev Nov 14, 2023
@a7medev a7medev deleted the feat/ios-startup-crashes branch November 14, 2023 09:31
HeshamMegid pushed a commit that referenced this pull request Nov 14, 2023
@a7medev @HeshamMegid
feat(ios): add native-side init API for startup crashes (#1056)
d8e4b0d 
Jira ID: MOB-13246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@a7medev @InstabugCI @abdelhamid-f-nasser