Skip to content

Conversation

@OpenPj
Copy link
Collaborator

@OpenPj OpenPj commented Jan 11, 2021

This is the italian translation of the Contributor section.
Hope this helps
^__^

@OpenPj OpenPj requested a review from a team as a code owner January 11, 2021 15:54
@rrrutledge
Copy link
Contributor

Wow! So great! Maybe @dottorblaster could have a look again?

@rrrutledge rrrutledge added Article Contributor Translation If you'd like to translate our material to you language. Translations are very welcome! :D labels Jan 12, 2021
@dottorblaster
Copy link
Collaborator

Oh wow, sure!

@rrrutledge
Copy link
Contributor

Hey @dottorblaster, thanks so much for being willing to have a look! Just wanted to remind if it works out for you to have time on this? If not that's OK, too, just let us know. Thanks!

@dottorblaster
Copy link
Collaborator

@rrrutledge thanks for the reminder, I actually have some comments pending and I have to finish up the review, I was slower than I thought, sorry!

Copy link
Collaborator

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OpenPj astonishing work! Some comments and I think it'll be fine 😄

@rrrutledge
Copy link
Contributor

Thank you so much for reviewing, @dottorblaster

@dottorblaster
Copy link
Collaborator

@rrrutledge no problem! Can I ask you to appear in some proofreading credits maybe? I consider this a valuable contribution ❤️

@rrrutledge
Copy link
Contributor

@dottorblaster can you make one of your PR comments as a commit suggestion instead of text comment? I believe that will cause your name to show up in the contributors list automatically, based on GitHub commit history.

@tsadler1988 tsadler1988 linked an issue Feb 4, 2021 that may be closed by this pull request
@dottorblaster
Copy link
Collaborator

@rrrutledge I'll try, thanks for the suggestion!

@dottorblaster
Copy link
Collaborator

@rrrutledge I turned every comment to a suggestion, this way you or @OpenPj can directly commit the changes and the review should be very smooth.

@rrrutledge
Copy link
Contributor

That is so awesome, @dottorblaster! Easier to review and you get the credit that you surely deserve!

@dottorblaster
Copy link
Collaborator

It sure isn't a matter of deserving, it's much more a thing like "I wanna proudly show I was part of this", I'm learning a lot about team collaboration through this and in fact I wanted to thank you and @OpenPj :-)

OpenPj and others added 10 commits February 24, 2021 12:14
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
OpenPj and others added 6 commits February 24, 2021 12:16
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
@OpenPj
Copy link
Collaborator Author

OpenPj commented Feb 24, 2021

Sorry for this delay, I finally reviewed all the improvements suggested by @dottorblaster 😅
Thank you so much for your review!

Copy link
Collaborator

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work all!

@rrrutledge rrrutledge merged commit 2eb6a8a into InnerSourceCommons:master Feb 24, 2021
@rrrutledge
Copy link
Contributor

Will work over the upcoming week to get this on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Article Contributor Translation If you'd like to translate our material to you language. Translations are very welcome! :D

3 participants