- Notifications
You must be signed in to change notification settings - Fork 47
Italian translation of the Contributor section #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Wow! So great! Maybe @dottorblaster could have a look again? |
| Oh wow, sure! |
| Hey @dottorblaster, thanks so much for being willing to have a look! Just wanted to remind if it works out for you to have time on this? If not that's OK, too, just let us know. Thanks! |
| @rrrutledge thanks for the reminder, I actually have some comments pending and I have to finish up the review, I was slower than I thought, sorry! |
dottorblaster left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OpenPj astonishing work! Some comments and I think it'll be fine 😄
contributor/it/04-mechanics-of-contributing-article-it.asciidoc Outdated Show resolved Hide resolved
contributor/it/04-mechanics-of-contributing-article-it.asciidoc Outdated Show resolved Hide resolved
contributor/it/04-mechanics-of-contributing-article-it.asciidoc Outdated Show resolved Hide resolved
contributor/it/04-mechanics-of-contributing-article-it.asciidoc Outdated Show resolved Hide resolved
| Thank you so much for reviewing, @dottorblaster ❗ |
| @rrrutledge no problem! Can I ask you to appear in some proofreading credits maybe? I consider this a valuable contribution ❤️ |
| @dottorblaster can you make one of your PR comments as a commit suggestion instead of text comment? I believe that will cause your name to show up in the contributors list automatically, based on GitHub commit history. |
| @rrrutledge I'll try, thanks for the suggestion! |
| @rrrutledge I turned every comment to a suggestion, this way you or @OpenPj can directly commit the changes and the review should be very smooth. |
| That is so awesome, @dottorblaster! Easier to review and you get the credit that you surely deserve! |
| It sure isn't a matter of deserving, it's much more a thing like "I wanna proudly show I was part of this", I'm learning a lot about team collaboration through this and in fact I wanted to thank you and @OpenPj :-) |
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
Co-authored-by: Alessio Biancalana <dottorblaster@gmail.com>
| Sorry for this delay, I finally reviewed all the improvements suggested by @dottorblaster 😅 |
dottorblaster left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
rrrutledge left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work all!
| Will work over the upcoming week to get this on the website. |
This is the italian translation of the Contributor section.
Hope this helps
^__^