- Notifications
You must be signed in to change notification settings - Fork 47
Add revisioned slides for PO videos (Segment 4) #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| I'd love to get feedback and then consensus before sending the slides out to O'Reilly. |
gruetter left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Max. The slides look terrific 8P. No really - well done. I do have some comments.
- 02_primer-01_requirements:
s/process/processess/Have basic/Have a basics/committer'/committerands/contributor's/contributor(as per recommendation of my buddy from the UK)
- 03_body_pr1-02_complaints
s/in fighting/infighting
- 04_body_pt2-01_benefits
- Proposal:
s/Open code/Code is accessible - Proposal:
s/Planning is transparent - Proposal:
s/Documentation is accessible - What are you referring to with negotiations, @maxcapraro ? With agile and InnerSource, too (IMHO), the developers have more say than in other models.
- Proposal:
- 04_body_pt2-03-examples
- not sure what Refactorization is ;). I'd say the modularisation is a result of the refactoring, if I understand this right. So maybe
s/and/and, as a result,Also, Payments is referring to PayPal, I guess. Do we need to write that here? - Is there a benefit for ALM and FDI as well, or are there related metrics which have improved? If so, I propose we spell that out here.
- not sure what Refactorization is ;). I'd say the modularisation is a result of the refactoring, if I understand this right. So maybe
- 06_recap_takeaways-01-wrapup
- Proposal:
s/Middle management is tough/Being a middle manager can be tough s/planing/planning
- Proposal:
- 06_recap_takeaways-02-wrapup
- the abbreviation TC has not been used or introduced on previous slides. Proposal:
s/TCs/Trusted committers
- the abbreviation TC has not been used or introduced on previous slides. Proposal:
- 07_contact-01-isc
- We're on facebook? Oh dear, the end is nigh ;)
Other than that, the slides LGTM. Thanks a bunch for putting in the work, @maxcapraro !
| Thank you @gruetter. You reviewed this like a bosch :-) I can't take credit for the contents of the slides because they were done by @Silona (minus some changes after a review by Russ and me). I think all of your comments make a lot of sense. I'll incorporate them directly. Regarding the questions raised, it would be great if @Silona could tap into the discussion. |
| Awesome, @maxcapraro. I agree with everything from @gruetter. Also these comments.
|
| I provided some updates. Because the diff view doesn't work well for PNG files, I summarized the changes below (using ✔️ and @gruetter's review:
✔️ Fixed
✔️ Fixed
✔️ Fixed
There are multiple important remarks in your comment:
✔️ Fixed
✔️ Fixed @rrrutledge's review:
✔️ Fixed (added this to Screenlight)
✔️ Fixed. Good idea!
✔️ Fixed. Seems like I only pushed some of the PNG files for the last wrap-up-slide |
|
|
Changed the linkedin link and kicked out deadlink to facebook |
| Everything here looks good to me. |
| Thanks @rrrutledge. I'll merge this then. |
| Great! |
Update 08-conclusion.asciidoc
This MR revises the slides to the PO videos: