Skip to content

Conversation

@RJPlog
Copy link
Collaborator

@RJPlog RJPlog commented Jun 30, 2020

I finished Translation for chapter 02 and 03 of trusted committer section, compare #256

@RJPlog RJPlog requested a review from a team as a code owner June 30, 2020 11:53
@RJPlog RJPlog added Translation If you'd like to translate our material to you language. Translations are very welcome! :D Trusted Committer "Trusted Committer" Segments of the Learning Path labels Jun 30, 2020
@lenucksi lenucksi requested a review from MaineC July 1, 2020 14:14
@rrrutledge rrrutledge requested review from arnom-ms and gruetter July 1, 2020 21:51
@rrrutledge rrrutledge requested a review from lenucksi July 9, 2020 15:50
Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this @RJPlog! 💯
A general plea here: Please create a new line for every sentence and do not insert line breaks within a sentence (e.g. after 80 characters) as this facilitates diffing and editing with Git (and GitHub). (Might be more for future articles)

I've added a bunch of commit suggestions based on @arnom-ms's comments and a few based on own thoughs.. Just click "Add suggestion to batch" and then "commit batch" at the top or use the individual commit suggestion menu to integrate them without having to bother with manual edits.

@RJPlog RJPlog force-pushed the 256-translate-trusted-committer-chapter02-03 branch from 64552ed to 24d5cf6 Compare July 18, 2020 19:25
@RJPlog
Copy link
Collaborator Author

RJPlog commented Jul 19, 2020

thx for the reviews! I changed both files accoring to the recommendations. There are some comments about commas, I removed them even if they seem to be correct, at least in the view of somebody who know's better than me, but also for my understandig they are to much. The files schould not be read by germanists but by SW-developers, so I guess it is better to have a good readability instead of grammatical correctness :-)

Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for integrating the comments. This looks good to me - I'd be glad to merge it if no one else has any comments.

Copy link
Member

@MaineC MaineC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first run through section 2

@MaineC
Copy link
Member

MaineC commented Jul 20, 2020

I went throught the first document. Some general comments:

First and most important of all: Thanks for taking the effort of translating this part of the learning path. It's amazing to see the content getting localized!

Some things that were weird to read for me: I would leave community as community instead of translating it to Organisation - the latter to me sounds more like the entire company or a rigid department in a company while InnerSource communities to me feel much more fluid and flexible.

I'd also leave things like release and ownership in their original terms, unless I'm entirely mistaken I have heard the term ownership in German agile literature as well.

One weird thing: GitHub seems to break the Umlaut letters when switching to review suggestions. Did anyone else have that issue, or is that just me on a Ubuntu machine using Firefox?

Copy link
Member

@MaineC MaineC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments to the second section.

RJPlog and others added 11 commits August 6, 2020 11:28
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
RJPlog and others added 9 commits August 6, 2020 11:37
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
@RJPlog
Copy link
Collaborator Author

RJPlog commented Aug 6, 2020

Thanks MaineC for the review, it took a while until I had time to look through due to some heavy load in the office and also the "Freibad" season :-). I will keep the spirit of your suggestions in the next rounds.

@lenucksi
Copy link
Member

lenucksi commented Aug 6, 2020

Thanks MaineC for the review, it took a while until I had time to look through due to some heavy load in the office and also the "Freibad" season :-). I will keep the spirit of your suggestions in the next rounds.

Looks like all review comments have been addressed - I'm happy to merge if you don't see anything blocking this.
If @arnom-ms wants to take a look he's also invited to do so.

@arnom-ms
Copy link
Collaborator

This looks great , thank you. One small nit: The use of "organization" and "community" in the two articles is not quite consistent, and I would suggest to go through and align the use of the term.

@RJPlog
Copy link
Collaborator Author

RJPlog commented Sep 6, 2020

I just went again to all comments of chapter 02. Hopefully I have adapted now every comment. 03 is open, hope to close this soon

@RJPlog
Copy link
Collaborator Author

RJPlog commented Sep 6, 2020

Now I went also through all comments of chapter 03. Every comment should be considered now.

Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all the continuous work to factor in all the suggestions and requests, @RJPlog. This looks great right now and hence ab die Post damit!

@lenucksi lenucksi merged commit 642d07b into InnerSourceCommons:master Sep 7, 2020
@RJPlog RJPlog deleted the 256-translate-trusted-committer-chapter02-03 branch October 1, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Article Translation If you'd like to translate our material to you language. Translations are very welcome! :D Trusted Committer "Trusted Committer" Segments of the Learning Path

4 participants