- Notifications
You must be signed in to change notification settings - Fork 47
translation for trusted committer chapter 02 and 03 to german added #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation for trusted committer chapter 02 and 03 to german added #287
Conversation
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
lenucksi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this @RJPlog! 💯
A general plea here: Please create a new line for every sentence and do not insert line breaks within a sentence (e.g. after 80 characters) as this facilitates diffing and editing with Git (and GitHub). (Might be more for future articles)
I've added a bunch of commit suggestions based on @arnom-ms's comments and a few based on own thoughs.. Just click "Add suggestion to batch" and then "commit batch" at the top or use the individual commit suggestion menu to integrate them without having to bother with manual edits.
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
64552ed to 24d5cf6 Compare | thx for the reviews! I changed both files accoring to the recommendations. There are some comments about commas, I removed them even if they seem to be correct, at least in the view of somebody who know's better than me, but also for my understandig they are to much. The files schould not be read by germanists but by SW-developers, so I guess it is better to have a good readability instead of grammatical correctness :-) |
lenucksi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for integrating the comments. This looks good to me - I'd be glad to merge it if no one else has any comments.
MaineC left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first run through section 2
| I went throught the first document. Some general comments: First and most important of all: Thanks for taking the effort of translating this part of the learning path. It's amazing to see the content getting localized! Some things that were weird to read for me: I would leave community as community instead of translating it to Organisation - the latter to me sounds more like the entire company or a rigid department in a company while InnerSource communities to me feel much more fluid and flexible. I'd also leave things like release and ownership in their original terms, unless I'm entirely mistaken I have heard the term ownership in German agile literature as well. One weird thing: GitHub seems to break the Umlaut letters when switching to review suggestions. Did anyone else have that issue, or is that just me on a Ubuntu machine using Firefox? |
MaineC left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments to the second section.
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
trusted-committer/de/03-keeping-the-community-healthy-de.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
| Thanks MaineC for the review, it took a while until I had time to look through due to some heavy load in the office and also the "Freibad" season :-). I will keep the spirit of your suggestions in the next rounds. |
Looks like all review comments have been addressed - I'm happy to merge if you don't see anything blocking this. |
| This looks great , thank you. One small nit: The use of "organization" and "community" in the two articles is not quite consistent, and I would suggest to go through and align the use of the term. |
| I just went again to all comments of chapter 02. Hopefully I have adapted now every comment. 03 is open, hope to close this soon |
| Now I went also through all comments of chapter 03. Every comment should be considered now. |
lenucksi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for all the continuous work to factor in all the suggestions and requests, @RJPlog. This looks great right now and hence ab die Post damit!
I finished Translation for chapter 02 and 03 of trusted committer section, compare #256