Arnom ms german translations part1

[arnom-ms]

First batch of translations to German

[rrrutledge]

Neat! @MaineC (or others from her company) may want to review?

[lenucksi]

Great, thanks for starting this @arnom-ms!

A few quick comments before I can take more time to actually read the German parts later.

• Could you split out the English language fixes to the two articles into a separate PR?

Translation file structure

Since we discussed to use this PR as a way to iterate on the integration for translations the approach you hence propose is:

• Translated files go into their English language main version folders as subfolders using the main language identifier, i.e. introduction/de/<filename>.asciidoc
  • We will not use a full locale language identifer such as de_DE or es_ES but ISO639-1 strings.
• The filename of the translation will be identical to the original filename, i.e. introduction/de/01-introduction.asciidoc

[MaineC]

Here comes the first batch of more detailed review comments.

Overall: Thanks for going through the material and providing the German translation. I believe, this is an awesome first pull request towards providing translated material to those who would like to adopt InnerSource but don't speak English fluently.

[MaineC]

Here comes the first batch of more detailed review comments.

Overall: Thanks for going through the material and providing the German translation. I believe, this is an awesome first pull request towards providing translated material to those who would like to adopt InnerSource but don't speak English fluently.

[MaineC]

.oO(Seeing a "page takes too long" unicorn page from GitHub when submitting this batch of review comments just made me a tiny little but nervous. Thank you to the GitHub team for coding this interface such that my review work didn't get lost! <3 )

[rrrutledge]

• Translated files go into their English language main version folders as subfolders using the main language identifier, i.e. introduction/de/<filename>.asciidoc

  • We will not use a full locale language identifer such as de_DE or es_ES but ISO639-1 strings.

• The filename of the translation will be identical to the original filename, i.e. introduction/de/01-introduction.asciidoc

We should put this in the folder structure listed in the README.

[MaineC]

Some more comments :)

[MaineC]

Some more comments :)

[MaineC]

One piece of general feedback: For any future translations, at least for me personally, I'd appreciate going chapter by chapter. Reviews tend to be shorter then. Also when there are specific translation decisions (tone of voice, specific terms etc) we can make them in a short sample text and don't have to adjust the entire text retrospectively.

[maxcapraro]

This is great work, @arnom-ms. Wow! I proposed a couple of minor changes.

[rrrutledge]

Exciting! Makes me wish I spoke German!

[lenucksi]

Went over the open commit suggestions and discussions and merged uncritical ones and left idea on others.

[arnom-ms]

I think for this round we are good now, I can't merge it though as it is blocked by this comment #218 (comment)

[lenucksi]

Nice changes, LGTM.

We are not able to merge (GitHub prevents us). All feedback has been very valuable and addressed. Max has agreed.

[arnom-ms]

link to conversation with Max: https://innersourcecommons.slack.com/archives/D010XNN3NUB/p1585811241005800