Benefits of contributing article - style review and minor updates #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update 06-conclusion-article.asciidoc
sync with remote
Ludmila-N requested review from gruetter, lenucksi and rrrutledge and removed request for gruetter 
Contributor
| Great! Will look next week. |
lenucksi requested changes Dec 24, 2019
Member
lenucksi left a comment
lenucksi left a comment There was a problem hiding this comment.
Thanks for making this review, finding and fixing the broken parts. I've added a few extra typo fixes and a few comments one of which I think should definitely be addressed.
Co-Authored-By: Johannes Tigges <lenucksi@users.noreply.github.com>
Co-Authored-By: Johannes Tigges <lenucksi@users.noreply.github.com>
Co-Authored-By: Johannes Tigges <lenucksi@users.noreply.github.com>
rrrutledge approved these changes Dec 30, 2019
Contributor
rrrutledge left a comment
rrrutledge left a comment There was a problem hiding this comment.
LGTM. Improvements possible as well!
lenucksi approved these changes Jan 6, 2020
Member
lenucksi left a comment
lenucksi left a comment There was a problem hiding this comment.
Thanks for the changes, looks good to me now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.