Skip to content

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Nov 12, 2025

Closes #172

Proposed Changes

  • Support URL with a path prefix, currently we only support the root URL.
  • Some test cases with timeout will now use ConstantFlightServerDelayed class for consistent results.
  • Add a test case for "write_port_overwrite" because Codecov complains.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.96%. Comparing base (c35f372) to head (3fd9f01).

Additional details and impacted files
@@ Coverage Diff @@ ## main #173 +/- ## ========================================== + Coverage 69.79% 69.96% +0.16%  ========================================== Files 35 35 Lines 2314 2317 +3 ========================================== + Hits 1615 1621 +6  + Misses 699 696 -3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@NguyenHoangSon96 NguyenHoangSon96 requested review from jansimonb and karel-rehor and removed request for jansimonb and karel-rehor November 13, 2025 06:23
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path should be added also for query API

@NguyenHoangSon96
Copy link
Contributor Author

path should be added also for query API

I read that gRPC can't have a path prefix but I will check again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants