refactor(toggle): update overlay subscription filter to tuple #2898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updating the shared pipe operators in the igxToggle since newer rxjs overloads require specific numner of typed params, see ReactiveX/rxjs#3989.
Only pushing to the 7 update branch since I'm taking advantage of tuples spread support from 3.0 - microsoft/TypeScript#24897;
@kdinev This will resolve the typescript error alright, BUT only so you can finally get to the tsickle errors.
Despite ng 7 using Typescript 3+ the tsickle package only supports that from the latest 0.33.1 version from what I can see and there are still build errors at least when I tried on my machine.