Skip to content

Conversation

mddragnev
Copy link
Member

Closes #16035

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
@mddragnev mddragnev changed the title test(hgrid): add a test fix(grid): Add flex:1 to the display container so that it grows or shrinks to the available width of the grid Jul 8, 2025
@mddragnev mddragnev requested a review from MayaKirova July 8, 2025 14:06
@mddragnev mddragnev added the ❌ status: awaiting-test PRs awaiting manual verification label Jul 8, 2025
@mddragnev mddragnev requested a review from simeonoff July 8, 2025 14:07
@MarielaTihova MarielaTihova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 10, 2025
%grid-display-container-tr {
width: 100%;
overflow: visible;
flex: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is fine, however since it changes the size of the cell's virtual container you'll also have to change how right pinning positions the cells. It currently sets an incorrect offset so if you pin any column to the right, you'll see that it's not correctly positioned to the right edge of the grid:

image
@mddragnev mddragnev added ❌ status: awaiting-test PRs awaiting manual verification and removed ✅ status: verified Applies to PRs that have passed manual verification labels Aug 25, 2025
@mddragnev mddragnev requested a review from MayaKirova September 5, 2025 07:37
@MarielaTihova MarielaTihova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 25, 2025
@dkamburov dkamburov merged commit 95ce9e2 into 20.0.x Sep 25, 2025
5 checks passed
@dkamburov dkamburov deleted the mddragnev/fix-16035 branch September 25, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment