fix(ssr): resize observe and animation player errors #15095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
damyanpetev reviewed Nov 22, 2024
| this._innerPlayer = innerRenderer.engine.players[innerRenderer.engine.players.length - 1]; | ||
| const rendererEngine = innerRenderer.engine || innerRenderer.delegate.engine; | ||
| // A workaround because of Angular SSR is using some delegation. | ||
| this._innerPlayer = rendererEngine.players[rendererEngine.players.length - 1]; |
There was a problem hiding this comment.
Yeah, anything after accessing the internal _renderer can fail at any point. @wnvko it does seem like the referenced issue is resolved, how about we check if this can be removed entirely.
damyanpetev approved these changes Nov 22, 2024
damyanpetev changed the title damyanpetev added squash-merge 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #15081
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)