QueryBuilder Validation #14987
QueryBuilder Validation #14987
Conversation
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…ee change" This reverts commit 98b08df.
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into thristodorova/query-builder-field-validation
…b.com/IgniteUI/igniteui-angular into dmdimitrov/query-builder-improvements
…b.com/IgniteUI/igniteui-angular into thristodorova/query-builder-field-validation
projects/igniteui-angular/src/lib/query-builder/query-builder.directives.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/query-builder/query-builder.directives.ts Outdated Show resolved Hide resolved
…directives.ts Co-authored-by: Galina Edinakova <gedinakova@infragistics.com>
…directives.ts Co-authored-by: Galina Edinakova <gedinakova@infragistics.com>
CHANGELOG.md Outdated
| } | ||
| </ng-template> | ||
| ``` | ||
| - Added `IgxFieldValidators` that could be used to define basic validation of the search value input based on the field data type. |
There was a problem hiding this comment.
Can we make this a little more verbose and probably add some snippet?
projects/igniteui-angular/src/lib/query-builder/query-builder.component.spec.ts Outdated Show resolved Hide resolved
) * feat(query-builder): select only one return field in inner query * chore(query-builder): update resource string translations * chore(*): replace *ngIf with @if/@else --------- Co-authored-by: INFRAGISTICS\IPetrov <IPetrov@infragistics.com> Co-authored-by: teodosiah <teodosiah@gmail.com>
…va/query-builder-field-validation
| pipeArgs?: IFieldPipeArgs; | ||
| defaultTimeFormat?: string; | ||
| defaultDateTimeFormat?: string; | ||
| validators?: any[]; |
There was a problem hiding this comment.
This is still the base for ColumnType right? So this change would affect the the grid and we might have to consider that in the way we expose it for the QB.
Also not sure any[] is a good type for this, technically it's IFieldValidator[] from what I see. Guessing that's because the column already has an internal validators: Validator[] which doesn't match and would error out (that should be a hint).
While the declarative IFieldValidator would actually be better for Xplat purposes, it could be a bit limiting to the validators we support without a mechanism to extend them. This might force us to consider the options for the column validation on xplat as well to keep those in sync.
| There has been no recent activity and this PR has been marked inactive. |
github-actions bot added the status: inactive | There has been no recent activity and this PR has been marked inactive. |
github-actions bot added the status: inactive 
Related to #14647
Specification - https://github.com/IgniteUI/igniteui-angular/wiki/Query-Builder-Validation-Specification
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)