Allow negative values in filter input #14477
Conversation
MonikaKirkova added grid: filter-ui version: 18.1.x ❌ status: awaiting-test 
| [value]="value" | ||
| (input)="onInput($event)" | ||
| [type]="type" | ||
| type="text" |
There was a problem hiding this comment.
This is a really major change in the filtering UI which may cause other problems. The number input actually allows typing - & + signs, so the problem seems to be in the filtering logic itself. I believe the problem is in the IgxGridFilteringRowComponent's "onInput event handler. When the target's value is just "-" (or + actually) it is resolved as NaN, hence the behavior you are observing. I suggest we account for this specific scenario by adding something similar to:
public onInput(eventArgs) {
.....
const target = eventArgs.target;
if (!target.value && this.column.dataType === GridColumnDataType.Number) {
return;
}
if (this.column.dataType === GridColumnDataType.DateTime) {
....
| return; | ||
| } | ||
| } else { | ||
| if (val === '') { |
There was a problem hiding this comment.
Doesn't this if eliminate the need of the newly added check in onInput?
| Closing this as it will duplicate with the mass merges. |
Closes #14086
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)