fix(excelStyleFilter): correct sorting in the excel style filter dropdown - master #14416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
georgianastasov added ❌ status: awaiting-test 
gedinakova requested changes Jul 16, 2024
| | ||
| const sortingDirection = isDescendingDirection ? SortingDirection.Desc : SortingDirection.Asc; | ||
| | ||
| this.uniqueValues = this.column.sortStrategy.sort( |
Contributor
There was a problem hiding this comment.
How can we be certain that everyone would want that? If this change is indeed necessary, we should probably think of a way to give them control on this, not to guess what should happen.
| return value; | ||
| } | ||
| | ||
| private checkSortingDirection(items: any[]): boolean { |
Contributor
There was a problem hiding this comment.
'checkSortingDirection' name does not imply that it would return true when the direction is descending. We need a more appropriate name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #14333
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)