Skip to content

Conversation

@Volen99
Copy link
Contributor

@Volen99 Volen99 commented Apr 6, 2022

Closes #11327

Related to #11139

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
@Volen99 Volen99 requested a review from hanastasov April 6, 2022 07:15
@Volen99 Volen99 added 🐛 bug Any issue that describes a bug ❌ status: awaiting-test PRs awaiting manual verification labels Apr 6, 2022
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test:

  1. Prepare a filtering expressions array (to include date and datetime type column)
    const stateFiltering = { filtering: filteringExpressions }
  2. Set state on the grid using the prepared filtering expressions
    state.setState(stateFiltering );
  3. Verify grid state is restored correctly
    expect(grid.filteringExpressions).toBe(stateFiltering.filtering)
@hanastasov hanastasov removed the ❌ status: awaiting-test PRs awaiting manual verification label Apr 7, 2022
@hanastasov
Copy link
Contributor

dateTime column is not available in 11.1, so closing this PR

@hanastasov hanastasov closed this Apr 7, 2022
@ChronosSF ChronosSF deleted the VDyulgerov/fix-broken-dateTime-filtering-11.1.x branch June 7, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Any issue that describes a bug

3 participants