Skip to content
This repository was archived by the owner on Jul 18, 2024. It is now read-only.

Conversation

dolph
Copy link
Member

@dolph dolph commented Nov 17, 2017

No description provided.

Copy link

@mlangbehn mlangbehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we making this change?

@dolph
Copy link
Member Author

dolph commented Nov 21, 2017

My apologies for not entering a description (I opened a lot of similar PR's!). I'm standardizing the LICENSE file across all of our journey repositories to exactly match the license file produced by GitHub's licensing tool. In many cases, our license files just contained random copy/paste issues (such as extra whitespace, broken indentation, missing a newline at the end of the file, etc). In other cases, license files were missing altogether, or were not licensed correctly. However, in this case, it looks like a relatively inconsequential change (perhaps the defacto Apache license switched from curly braces to brackets since this file was created). I'd still appreciate merging this, though, just so our repositories are one step closer to being consistent with each other.

@dolph dolph changed the title Add license documentation Revise license documentation Nov 21, 2017
stevemar
stevemar previously approved these changes Dec 19, 2017
Copy link

@stevemar stevemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failing CI is unrelated, we can still merge this

Copy link
Member

@loafyloaf loafyloaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loafyloaf loafyloaf merged commit 2dcfb9f into IBM:master Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants