Add Dockerfile and docker_build.sh script #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| Fine, but in fact, there are 2 choices that can build this lib. Can you improve the script? Thank you! |
Contributor Author
| Of course I'm sorry, I couldn't attend to your message until now. You want me to remove the redundant build command (python3 setup.py build_ext -i)? …On Fri, Feb 28, 2020 at 6:11 PM Huelse ***@***.***> wrote: Merged #8 <#8> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8?email_source=notifications&email_token=AD5CJL6IIMWDYZLQDTN3GELRE7Q2PA5CNFSM4K5OJTWKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW654GGI#event-3082535705>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD5CJL4FPA6MJOX6KPZVR7LRE7Q2PANCNFSM4K5OJTWA> . -- בברכה אורי אריאל יהלום |
Owner
| @uriariel I mean, it don't need to compile the pybind11, and only needs run |
Contributor Author
| Ok, will do. …On Mon, Mar 2, 2020, 10:29 Huelse ***@***.***> wrote: @uriariel <https://github.com/uriariel> I mean, it don't need to compile the pybind11, and only needs run python3 setup.py install — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8?email_source=notifications&email_token=AD5CJLZ52NHVQ75O67Y7HALRFNU43A5CNFSM4K5OJTWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENOL4CY#issuecomment-593280523>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD5CJLZQ7DU4EICPKOHCX4DRFNU43ANCNFSM4K5OJTWA> . |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I thought that it might be a good idea to add docker integration into the project :)