3.4.5 rpickle tests expanded #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Prevent the scripts from running if a pervious command fails.
The unit tests no longer chain from eachother but instead use core functions to the test class. This means if an earlier one fails they wont all fail, but they still validate the types and use of objects. This will help better identify things that are unpickleable rather than a dependancy of theirs that is not pickleable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Tests no validate types, use core functions rather than chaining tests, and the docker scripts now have failure catching, preventing previously built containers from hiding errors.
This also fixes the docker script context path so it can find the correct dockerfile.
This should now also work when backported to 3.3.2 shortly.