Minor Docker convention and rename update #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Build script "build_docekr.sh" renamed to build_docker.sh .
The previous docker file would generate too many intermediate images, as each stage e.g each RUN command would store a seperate image, and by common practice/ convention people instead use RUN command && \ command to prevent an arbitrary number of intermediates being spawned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is only a small update which:
Changes the spelling of docker in the previously "build_docekr" file.
Updates to the dockerfile to use more standard conventions to prevent an arbitrary number of intermediary images to be built and take up space.
Addition of a .dockerignore file to reduce the size of the build context being sent to docker.