Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Conversation

@zrss
Copy link

@zrss zrss commented Nov 20, 2018

Fixes: #276

thoughts ?

and if u tend to keep the owner, u should run the cmd with root permission (or just a root user) as the owner maybe missing in your host

@zrss
Copy link
Author

zrss commented Nov 20, 2018

/assign @aaron-prindle

hi aaron-prindle, thx for the great tool, currently i use it to recover the container root fs to do some security validation. yeah, i encounter the case, i have to check the newly added file should not be uid 0 (root user)

so i open a PR for improving it, if that have some benefits, could u have time for help me tune it better.

or any idea to solve my problem

@aaron-prindle
Copy link
Collaborator

Hi @zrss, thanks for the PR! The code looks good, do you think you could add a section for the flag in the README.md here: https://github.com/GoogleContainerTools/container-diff#other-flags

Thanks for adding this!

@zrss
Copy link
Author

zrss commented Nov 22, 2018

@aaron-prindle , thanks for the reply. 😅 , and i still got stuck at some cases ... still working on it

@nkubala
Copy link
Contributor

nkubala commented Feb 20, 2019

@zrss is this PR still active?

@donmccasland donmccasland self-requested a review May 13, 2019 22:09
Copy link
Member

@donmccasland donmccasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still planning on landing this?

@nkubala nkubala closed this May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants