This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Set/unset write bit on unwriteable directories when unpacking tars #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pkg/util/tar_utils.go Outdated
| logrus.Debugf("Write permission bit not set on %s by default; setting manually", target) | ||
| originalMode := mode | ||
| mode = mode | (1 << uint(7)) | ||
| defer os.Chmod(target, originalMode) |
Collaborator
There was a problem hiding this comment.
Chmod can return an Error, might be worth not deferring it and handling the error
dlorenc previously approved these changes Mar 27, 2018
Contributor Author
| Unfortunately this only partially solves this issue, because once we reset the permissions outside of the scope of the user we can't remove or modify any of the files, meaning that we can't properly clean up the image on the filesystem. Still, this is better than what we had before, so I changed the message to a warn. The only real way to fix this issue is by moving the unpacked image from disk to memory, which is well outside the scope of this PR. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When unpacking image tars, sometimes we run into directories that were unwriteable in the image. The directories will get created by container-diff, but then any subsequent files being written to the directory will fail. To fix this, we set the world-writable bit on the directory when we create it, then defer resetting the permissions so we can write all of its contents.
Fixes #168