This repository was archived by the owner on Mar 27, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork 236
History integ tests #14
Merged
abbytiz merged 3 commits into GoogleContainerTools:master from abbytiz:historyIntegTests Aug 11, 2017
Merged
Changes from 2 commits
Commits
Show all changes
3 commits Select commit Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| [ | ||
| { | ||
| "DiffType": "HistoryDiffer", | ||
| "Diff": { | ||
| "Image1": "gcr.io/gcp-runtimes/diff-base", | ||
| "Image2": "gcr.io/gcp-runtimes/diff-modified", | ||
| "Adds": [ | ||
| "/bin/sh -c #(nop) ADD file:aa56bc8f2fea9c0c81ca085bfa273ad1a3b0d46f51b8c9c61b483340c902024f in /" | ||
| ], | ||
| "Dels": [ | ||
| "/bin/sh -c #(nop) ADD file:5dde1d6e0f6362350d7ebbc85ce82cf4c5032fb74d2c6235dac172e8e102c00f in /", | ||
| "mkdir /home/test" | ||
| ] | ||
| } | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| [ | ||
| { | ||
| "DiffType": "HistoryDiffer", | ||
| "Diff": { | ||
| "Image1": "gcr.io/gcp-runtimes/pip-base", | ||
| "Image2": "gcr.io/gcp-runtimes/pip-modified", | ||
| "Adds": [ | ||
| "/bin/bash" | ||
| ], | ||
| "Dels": [] | ||
| } | ||
| }, | ||
| { | ||
| "DiffType": "PipDiffer", | ||
| "Diff": { | ||
| "Image1": "gcr.io/gcp-runtimes/pip-base", | ||
| "Packages1": {}, | ||
| "Image2": "gcr.io/gcp-runtimes/pip-modified", | ||
| "Packages2": { | ||
| "mock": { | ||
| "python3.6": { | ||
| "Version": "2.0.0", | ||
| "Size": "504226" | ||
| } | ||
| }, | ||
| "pbr": { | ||
| "python3.6": { | ||
| "Version": "3.1.1", | ||
| "Size": "447110" | ||
| } | ||
| }, | ||
| "six": { | ||
| "python3.6": { | ||
| "Version": "1.10.0", | ||
| "Size": "30098" | ||
| } | ||
| } | ||
| }, | ||
| "InfoDiff": [ | ||
| { | ||
| "Package": "pip", | ||
| "Info1": [ | ||
| { | ||
| "Version": "9.0.1", | ||
| "Size": "3741310" | ||
| } | ||
| ], | ||
| "Info2": [ | ||
| { | ||
| "Version": "9.0.1", | ||
| "Size": "5289421" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "Package": "wheel", | ||
| "Info1": [ | ||
| { | ||
| "Version": "0.29.0", | ||
| "Size": "103348" | ||
| } | ||
| ], | ||
| "Info2": [ | ||
| { | ||
| "Version": "0.29.0", | ||
| "Size": "103509" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rerun for pip diff changes but otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, and fixed the pip differ and tests so that the path is only what is necessary.