This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Add a cloudbuild.yaml for tag releases. #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This should finish up the release automation. |
nkubala reviewed Oct 23, 2017
| steps: | ||
| # Build the container that will do the go build. | ||
| - name: 'gcr.io/cloud-builders/docker' | ||
| args: ['build', '-t', 'builder', '-f', 'Dockerfile.build', '.'] |
There was a problem hiding this comment.
I don't see Dockerfile.build anywhere, do you need to check it in?
There was a problem hiding this comment.
It should have just been added in b726215
There was a problem hiding this comment.
Ah yep looks like my pull didn't finish before I said that, spoke too soon :)
nkubala approved these changes Oct 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.