Skip to content

Conversation

theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Jon Wayne Parrott added 2 commits July 7, 2016 12:43
Change-Id: I1593cb4b0a3032da21d70c2fcbc6b0e466d6b2ca
Change-Id: I4a37c5e2ce724ef2b130f76a97ca999aebec0d01

def test_index():
try:
main.redis_client.set('counter', 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a context in which this is actually running?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm about to push a commit to enable it on travis.

Change-Id: Ia6a094ddc5c71ddb286ec55d957753570e4ec4f3
@waprin
Copy link
Contributor

waprin commented Jul 7, 2016

lgtm

Change-Id: I27a2798349373307711a842ede87f4d015bcda4b
@theacodes
Copy link
Contributor Author

@waprin thanks for the swift review. Will merge once the tests for the test god pass.

@theacodes theacodes merged commit bb6b63b into master Jul 7, 2016
@theacodes theacodes deleted the redis branch July 7, 2016 20:09
msampathkumar pushed a commit that referenced this pull request Nov 14, 2022
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
msampathkumar pushed a commit that referenced this pull request Nov 14, 2022
Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants