Skip to content

Conversation

@olavloite
Copy link
Collaborator

Add support for emulated savepoints. Setting and releasing savepoints work in all cases. Rolling back to a savepoint is not guaranteed to work, as the underlying implementation will rollback the entire transaction and retry up to where the savepoint was set. Note that the retry will only be executed if the transaction is actually used after the rollback.

Add support for emulated savepoints. Setting and releasing savepoints work in all cases. Rolling back to a savepoint is not guaranteed to work, as the underlying implementation will rollback the entire transaction and retry up to where the savepoint was set. Note that the retry will only be executed if the transaction is actually used after the rollback.
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #796 (8677a6d) into postgresql-dialect (001a719) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## postgresql-dialect #796 +/- ## ======================================================== - Coverage 89.61% 89.60% -0.01%  + Complexity 2366 2365 -1  ======================================================== Files 131 131 Lines 7837 7863 +26 Branches 1122 1122 ======================================================== + Hits 7023 7046 +23  - Misses 566 568 +2  - Partials 248 249 +1 
Flag Coverage Δ
all_tests 89.60% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gle/cloud/spanner/pgadapter/ConnectionHandler.java 87.68% <100.00%> (-0.73%) ⬇️
...google/cloud/spanner/pgadapter/error/SQLState.java 99.44% <100.00%> (+<0.01%) ⬆️
...panner/pgadapter/statements/BackendConnection.java 93.90% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@olavloite olavloite marked this pull request as ready for review April 27, 2023 07:44
@olavloite olavloite merged commit 570fb96 into postgresql-dialect May 4, 2023
@olavloite olavloite deleted the savepoint-support branch May 4, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant