Add Kokoro config for appengine-datastore #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #642 +/- ## ======================================= Coverage 48.52% 48.52% ======================================= Files 1 1 Lines 68 68 ======================================= Hits 33 33 Misses 35 35Continue to review full report at Codecov.
|
tbpg reviewed Jun 6, 2018
.kokoro/appengine-datastore.sh Outdated
| | ||
| export GCLOUD_PROJECT=nodejs-docs-samples-tests | ||
| STAGE_BUCKET=$GCLOUD_PROJECT | ||
| GCP_REGION=us-central1 |
There was a problem hiding this comment.
Confirming these don't need to be exported.
There was a problem hiding this comment.
Actually, I think I don't need those at all.
.kokoro/appengine-datastore.sh Outdated
| npm test | ||
| | ||
| # Exit on error | ||
| if [[ $CODE -ne 0 ]]; then |
There was a problem hiding this comment.
Could this be changed to exit $CODE (since exit 0 means success)? Not sure I understand how CODE gets assigned. I see the assignment in the trap, but that will run after this, right?
There was a problem hiding this comment.
This is how we do it in the other configs. Not sure if they report correctly, I don't understand CODE either. I'll simplify it for now. Let's see if it works.
tbpg approved these changes Jun 6, 2018
grayside pushed a commit that referenced this pull request Oct 26, 2022
* fix: adding headers in task request refactor: updating readme with same fix * refactor: lint fixes * fix: switch content-type expected * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Averi Kitsch <akitsch@google.com>
grayside pushed a commit that referenced this pull request Nov 3, 2022
* fix: adding headers in task request refactor: updating readme with same fix * refactor: lint fixes * fix: switch content-type expected * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Averi Kitsch <akitsch@google.com>
grayside pushed a commit that referenced this pull request Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [4.0.1](https://www.github.com/googleapis/cloud-profiler-nodejs/compare/v4.0.0...v4.0.1) (2020-07-09) ### Bug Fixes * **deps:** update dependency pretty-ms to v7 ([#642](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/642)) ([f69c7a7](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/f69c7a73b17c150c2b523412e430b5d1ac03e12a)) * **deps:** update dependency protobufjs to ~6.9.0 ([#634](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/634)) ([a90149c](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/a90149c4f91630d75bb41fab145713637736d21c)) * malformed tsconfig causing broken tests [#640](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/640) ([#647](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/647)) ([09c19c8](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/09c19c88a0ca137b7970c386730b145b66b77ec3)) * **deps:** update dependency teeny-request to v7 ([#652](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/652)) ([b46eb4f](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/b46eb4f2552871f405579100e4e916dbde5c60d8)) * typeo in nodejs .gitattribute ([#661](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/661)) ([92f46ac](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/92f46ac22a510c7bab05549b83779dd4f60096b7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 12, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [4.0.1](https://www.github.com/googleapis/cloud-profiler-nodejs/compare/v4.0.0...v4.0.1) (2020-07-09) ### Bug Fixes * **deps:** update dependency pretty-ms to v7 ([#642](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/642)) ([f69c7a7](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/f69c7a73b17c150c2b523412e430b5d1ac03e12a)) * **deps:** update dependency protobufjs to ~6.9.0 ([#634](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/634)) ([a90149c](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/a90149c4f91630d75bb41fab145713637736d21c)) * malformed tsconfig causing broken tests [#640](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/640) ([#647](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/647)) ([09c19c8](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/09c19c88a0ca137b7970c386730b145b66b77ec3)) * **deps:** update dependency teeny-request to v7 ([#652](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/652)) ([b46eb4f](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/b46eb4f2552871f405579100e4e916dbde5c60d8)) * typeo in nodejs .gitattribute ([#661](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/661)) ([92f46ac](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/92f46ac22a510c7bab05549b83779dd4f60096b7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
First config for Kokoro. Once everything works I'll make it configurable so the build file can be used for all AppEngine tests.