Skip to content

Conversation

@jmdobry
Copy link
Member

@jmdobry jmdobry commented Jan 14, 2016

No description provided.

@jmdobry jmdobry self-assigned this Jan 14, 2016
logging/list.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have veneer support for this now - can we use that instead?
https://github.com/GoogleCloudPlatform/gcloud-node#google-cloud-logging-beta

@jmdobry jmdobry force-pushed the logging branch 6 times, most recently from 45ae851 to a0ec2c0 Compare January 15, 2016 19:38
@jmdobry jmdobry assigned theacodes and unassigned jmdobry Jan 15, 2016
@jmdobry
Copy link
Member Author

jmdobry commented Jan 15, 2016

@jonparrott ready for review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, that's what the cloud-node logging docs say.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theacodes
Copy link

LGTM with small nits.

@jmdobry jmdobry force-pushed the logging branch 2 times, most recently from a386b52 to c5963c9 Compare January 15, 2016 22:37
jmdobry added a commit that referenced this pull request Jan 19, 2016
@jmdobry jmdobry merged commit b2272ca into master Jan 19, 2016
@jmdobry jmdobry deleted the logging branch January 19, 2016 17:48
telpirion pushed a commit that referenced this pull request Nov 9, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 9, 2022
…nter-insights (#2817) - feat: initial generation of templated files - feat: add initial samples (#2) - chore(deps): update dependency mocha to v9 (#3) - chore: release 1.0.0 (#1) - chore: release 1.0.1 (#12) - chore: release 1.0.2 (#18) - chore: release 1.1.0 (#21) - chore: release 1.2.0 (#26) - chore: release 1.2.1 (#29) - chore: release 1.3.0 (#36) - chore: release 1.4.0 (#40) - samples: get operation (#52) - samples: create conversation, create analysis, export data to BigQuery (#34) - samples: enable pubsub notifications (#48) - samples: modify TTL in create conversation with TTL sample (#57) - samples: create topic model (#49) - chore: release 1.5.0 (#58) - samples: set project-level TTL (#51) - samples: create custom highlights (#53) - chore: release 1.6.0 (#65) - chore: release 1.7.0 (#69) - chore: release 1.8.0 (#75) - chore: release 1.9.0 (#81) - chore(main): release 1.11.0 (#107) - build: add retries for flaky test (#109) - build!: update library to use Node 12 (#122) - chore(main): release 2.0.0 (#124) - fix(deps): update dependency @google-cloud/bigquery to v6 (#127) - fix(deps): update dependency @google-cloud/pubsub to v3 (#126) - chore(main): release 2.0.1 (#129) - chore(main): release 2.1.0 (#134) - chore(main): release 2.1.1 (#139) - chore(deps): update dependency uuid to v9 (#142)
rogerthatdev pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
NimJay pushed a commit that referenced this pull request Nov 10, 2022
* chore: lock files maintenance * chore: lock files maintenance
NimJay pushed a commit that referenced this pull request Nov 10, 2022
* chore: lock files maintenance * chore: lock files maintenance
ace-n pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
rogerthatdev pushed a commit that referenced this pull request Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ace-n pushed a commit that referenced this pull request Nov 16, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
NimJay pushed a commit that referenced this pull request Nov 19, 2022
NimJay pushed a commit that referenced this pull request Nov 19, 2022
jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this pull request Dec 12, 2022
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants