Add DLP quickstart + fix incorrect comments #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits August 3, 2017 13:35
jmdobry approved these changes Aug 3, 2017
dlp/quickstart.js Outdated
| } | ||
| }) | ||
| .catch((err) => { | ||
| console.log(`Error in inspectString: ${err.message || err}`); |
There was a problem hiding this comment.
Use console.error, otherwise LGTM
Codecov Report
@@ Coverage Diff @@ ## master #442 +/- ## ======================================= Coverage 83.84% 83.84% ======================================= Files 4 4 Lines 421 421 ======================================= Hits 353 353 Misses 68 68Continue to review full report at Codecov.
|
telpirion pushed a commit that referenced this pull request Nov 16, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
grayside pushed a commit that referenced this pull request Nov 16, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This was referenced Nov 16, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
grayside pushed a commit that referenced this pull request Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
unforced pushed a commit that referenced this pull request Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
* feat: updates effects profile sample with more guidance * feat: update test Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
* Fix typo in comments * Add DLP quickstart * Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@bshaffer - adding you as a reviewer to make sure this matches the PHP sample's style. Thanks!