Skip to content

Conversation

@pattishin
Copy link
Contributor

Benjamin E. Coe and others added 30 commits November 10, 2020 11:30
🤖 I have created a release \*beep\* \*boop\* --- ## 1.0.0 (2020-11-10) ### ⚠ BREAKING CHANGES * initial generation of library (#4) ### Features * initial generation ([182128b](https://www.github.com/googleapis/nodejs-ai-platform/commit/182128bfa593c787e2f0970ba224a68595b45971)) * initial generation of library ([#4](https://www.github.com/googleapis/nodejs-ai-platform/issues/4)) ([1b8db30](https://www.github.com/googleapis/nodejs-ai-platform/commit/1b8db30e243aac5d9dab74b00431c81dbf412a66)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
* feat: adds enhancements to library * chore: changes to synth.py * fix: broken pack n' play test * fix: add enhanced types to ts compiler * fix: project enabled * fix: adds docstrings to toValue(), fromValue() functions * fix: removing any * fix: edits to synth.py per reviewer * fix: add more test coverage * chore: added comment about conversion interface Co-authored-by: Sofia Leon <sofialeon@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: adds cleaner utility function Co-authored-by: Benjamin E. Coe <bencoe@google.com>
* Remove cleaning script from tests * Remove unnecessary imports
🤖 I have created a release \*beep\* \*boop\* --- ## [1.3.0](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.2.0...v1.3.0) (2021-01-14) ### Features * **samples:** adds samples for enhanced version of library ([#16](https://www.github.com/googleapis/nodejs-ai-platform/issues/16)) ([aef443c](https://www.github.com/googleapis/nodejs-ai-platform/commit/aef443c41b8a9a2199e0c5b100a5ab91444b0dfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
* build: increase retries and timeout for flaky tests
* build: increase retries and timeout for flaky tests
* samples: fix region tag * fix: per reviewer Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
* fix: reduced image size due to new file size limit (1.5 MB) * fix: more file sizing
* Add samples * Fix linter errors * Remove unnecessary samples and tests * Fix minor linter error * Remove unnecessary comments and other small updates * Update project id * Add samples * Fix linter errors * Remove unnecessary samples and tests * Fix minor linter error * Remove unnecessary comments and other small updates * Update project id * Remove terminal await calls * Fix configuration issues * Fix parsing error * Update samples/package.json * Update samples/predict-custom-trained-model.js * Fix async file access for Node 10 * Ensmallify the example image Co-authored-by: Eric Schmidt <erschmid@google.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Eric Schmidt <erschmid@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* Update create-custom-job.test.js Fix typo in path * Update create-custom-job.test.js * Update create-custom-job.test.js
* samples: adds batch prediction samples for text * samples: added tests * 🦉 Updates from OwlBot * fix: lint * fix: lint * fix: docs test Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:f93bb861d6f12574437bb9aee426b71eafd63b419669ff0ed029f4b7e7162e3f
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
* samples: adds missing Node.js samples
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@pattishin pattishin requested a review from a team as a code owner November 18, 2022 22:34
@snippet-bot
Copy link

snippet-bot bot commented Nov 18, 2022

Here is the summary of changes.

You are about to add 110 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@pattishin pattishin requested a review from a team as a code owner November 21, 2022 21:54
@NimJay
Copy link
Contributor

NimJay commented Nov 21, 2022

I created a test pull-request at googleapis/nodejs-ai-platform#469 (in the original repo).
I wanted to double check whether these tests were already failing in the original repo (googleapis/nodejs-ai-platform).
More specifically, I'm running the create-featurestore-fixed-nodes-sample.test.js tests.
create-featurestore-fixed-nodes-sample.test.js is passing in the original repo.

This confirms that we're just missing some CI environment setup in GoogleCloudPlatform/nodejs-docs-samples that we already have inside googleapis/nodejs-ai-platform.

@pattishin
Copy link
Contributor Author

I created a test pull-request at googleapis/nodejs-ai-platform#469 (in the original repo). I wanted to double check whether these tests were already failing in the original repo (googleapis/nodejs-ai-platform). More specifically, I'm running the create-featurestore-fixed-nodes-sample.test.js tests. create-featurestore-fixed-nodes-sample.test.js is passing in the original repo.

This confirms that we're just missing some CI environment setup in GoogleCloudPlatform/nodejs-docs-samples that we already have inside googleapis/nodejs-ai-platform.

Thanks Nim! Currently updating this as we speak 👍🏼 I'll put a WIP in the PR title

@pattishin pattishin changed the title migrate code from googleapis/nodejs-ai-platform migrate code from googleapis/nodejs-ai-platform (⚠️ WIP) Nov 21, 2022
@pattishin pattishin changed the title migrate code from googleapis/nodejs-ai-platform (⚠️ WIP) migrate code from googleapis/nodejs-ai-platform Nov 22, 2022
@pattishin
Copy link
Contributor Author

pattishin commented Nov 22, 2022

Added a couple of new secrets to the project, so tests are passing now. All ready for another look! 👓

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the quickstart, otherwise LGTM. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.