Skip to content

Bring Logging samples up to standard. #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2016
Merged

Bring Logging samples up to standard. #183

merged 1 commit into from
Aug 21, 2016

Conversation

@jmdobry
Copy link
Member

@jmdobry jmdobry commented Aug 19, 2016 •
edited
Loading

Fixes #175

  • - Sinks
  • - Logs
@jmdobry jmdobry self-assigned this Aug 19, 2016
@jmdobry
Copy link
Member Author

jmdobry commented Aug 19, 2016

@ace-n Ready for review, when you have a moment.
@codecov-io
Copy link

codecov-io commented Aug 20, 2016 •
edited
Loading

Current coverage is 87.42% (diff: 97.87%)

Merging #183 into master will increase coverage by 1.10%

@@ master #183 diff @@ ========================================== Files 58 57 -1 Lines 2383 2409 +26 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 2057 2106 +49  + Misses 326 303 -23  Partials 0 0

Powered by Codecov. Last update 47baf19...b5f6fde
ace-n
ace-n reviewed Aug 21, 2016
View reviewed changes
logging/logs.js
config.filter = options.filter;
}
if (options.limit) {
config.pageSize = options.limit;
Copy link
Contributor

@ace-n ace-n Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the options values to the names config uses? That way we can just pass options in as config.
Copy link
Member Author

@jmdobry jmdobry Aug 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried that. gcloud-node throws an error if the options contains keys that aren't official options.
ace-n
ace-n reviewed Aug 21, 2016
View reviewed changes
logging/system-test/sinks.test.js

'use strict';

var gcloud = require('google-cloud');
Copy link
Contributor

@ace-n ace-n Aug 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 (is there any way to not require the whole thing?)
Copy link
Member Author

@jmdobry jmdobry Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but would have to do this instead:

var Logging = require('@google-cloud/logging'); var Storage = require('@google-cloud/storage'); var BigQuery = require('@google-cloud/bigquery'); var PubSub = require('@google-cloud/pubsub');
Copy link
Contributor

@ace-n ace-n Aug 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense.
@ace-n
Copy link
Contributor

ace-n commented Aug 21, 2016

LGTM, other than my comments.
@jmdobry
Copy link
Member Author

jmdobry commented Aug 21, 2016

Cool. Just pushed again, will merge when green.
@jmdobry
Copy link
Member Author

jmdobry commented Aug 21, 2016

Thanks!
@jmdobry jmdobry merged commit ae4d6ae into master Aug 21, 2016
@jmdobry jmdobry deleted the logging branch August 21, 2016 03:12
This was referenced Mar 11, 2022
Open
Open
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@JustinBeckwith
feat: add .repo-metadata.json; allows us to generate new docs site (#183
17be93f 
)
@ace-n ace-n mentioned this pull request Nov 11, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@JustinBeckwith
feat: add .repo-metadata.json; allows us to generate new docs site (#183
c7f7a93 
)
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@muraliQlogic @JustinBeckwith
docs(samples): update samples to use async/await and mocha (#183)
22c773a
@ace-n ace-n mentioned this pull request Nov 14, 2022
Closed
ace-n pushed a commit that referenced this pull request Nov 14, 2022
feat: add .repo-metadata.json; allows us to generate new docs site (#183
995c65c 
)
ace-n pushed a commit that referenced this pull request Nov 15, 2022
feat: add .repo-metadata.json; allows us to generate new docs site (#183
1a1b12c 
)
@ace-n ace-n mentioned this pull request Nov 15, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 15, 2022
feat: add .repo-metadata.json; allows us to generate new docs site (#183
096e16a 
)
@telpirion telpirion mentioned this pull request Nov 16, 2022
Merged
telpirion pushed a commit that referenced this pull request Nov 16, 2022
@renovate @JustinBeckwith
chore(deps): update dependency @google-cloud/storage to v2 (#183)
279b932
ace-n pushed a commit that referenced this pull request Nov 17, 2022
feat: add .repo-metadata.json; allows us to generate new docs site (#183
5e1075f 
)
ace-n pushed a commit that referenced this pull request Nov 17, 2022
feat: add .repo-metadata.json; allows us to generate new docs site (#183
00086f7 
)
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
feat: add .repo-metadata.json; allows us to generate new docs site (#183
7a264cd 
)
NimJay pushed a commit that referenced this pull request Nov 18, 2022
@release-please
chore: release 2.1.1 (#183)
982e371 
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.1](https://www.github.com/googleapis/nodejs-datacatalog/compare/v2.1.0...v2.1.1) (2020-07-09) ### Bug Fixes * typeo in nodejs .gitattribute ([#182](https://www.github.com/googleapis/nodejs-datacatalog/issues/182)) ([9e46bfc](https://www.github.com/googleapis/nodejs-datacatalog/commit/9e46bfce7847084d24d85218d5a294ff7c46e2ff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@NimJay NimJay mentioned this pull request Nov 18, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 18, 2022
@release-please @NimJay
chore: release 2.1.1 (#183)
c5ae20f 
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.1](https://www.github.com/googleapis/nodejs-datacatalog/compare/v2.1.0...v2.1.1) (2020-07-09) ### Bug Fixes * typeo in nodejs .gitattribute ([#182](https://www.github.com/googleapis/nodejs-datacatalog/issues/182)) ([9e46bfc](https://www.github.com/googleapis/nodejs-datacatalog/commit/9e46bfce7847084d24d85218d5a294ff7c46e2ff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@muraliQlogic
docs(samples): update samples to use async/await and mocha (#183)
b9c3f6a
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@muraliQlogic
docs(samples): update samples to use async/await and mocha (#183)
41c76ec
jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this pull request Dec 12, 2022
@renovate-bot
chore(deps): update module go.uber.org/zap to v1.24.0 (GoogleCloudPla…
9176781 
…tform#183)
kweinmeister pushed a commit that referenced this pull request Jan 11, 2023
@release-please
chore(main): release 2.0.0 (#184)
5efdd94 
🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/nodejs-retail@v1.8.1...v2.0.0) (2022-06-20) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#181) ### Features * allow users to disable spell check in search requests ([#183](googleapis/nodejs-retail#183)) ([05005ea](googleapis/nodejs-retail@05005ea)) ### Bug Fixes * **deps:** update dependency @google-cloud/bigquery to v6 ([#186](googleapis/nodejs-retail#186)) ([fc07923](googleapis/nodejs-retail@fc07923)) ### Build System * update library to use Node 12 ([#181](googleapis/nodejs-retail#181)) ([809853f](googleapis/nodejs-retail@809853f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
@renovate @JustinBeckwith
fix(deps): update dependency @google-cloud/pubsub to ^0.21.0 (#183)
5222ba9
@Shabirmean Shabirmean mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@jmdobry @codecov-io @ace-n