Skip to content

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Nov 8, 2017

This PR is to primarily fix a typo in Guice + Endpoints Gradle script.

@frankyn frankyn requested a review from lesv November 8, 2017 00:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2017
lesv
lesv previously approved these changes Nov 8, 2017
@lesv
Copy link
Contributor

lesv commented Nov 8, 2017

@kurtisvg I suspect this bug isn't Franks.
@frankyn Please resolve conflicts then ok to merge.

@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2017
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2017
@kurtisvg
Copy link
Contributor

kurtisvg commented Nov 8, 2017

@lesv It's failing to test because of merge conflicts.

@frankyn frankyn merged commit 2ff682d into master Nov 8, 2017
@frankyn frankyn deleted the guice-gradle-fix branch November 8, 2017 20:46
minherz pushed a commit that referenced this pull request Nov 9, 2022
…913) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.7` -> `2.8.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/compatibility-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/confidence-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.8`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;288-httpsgithubcomgoogleapisjava-corecomparev287v288-2022-08-04) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.7...v2.8.8) ##### Dependencies - update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#&#8203;897](https://togithub.com/googleapis/java-core/issues/897)) ([29e4fc9](https://togithub.com/googleapis/java-core/commit/29e4fc93d5d4d50f7de85eae7a8150314cca6f43)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-errorreporting). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
minherz pushed a commit that referenced this pull request Nov 9, 2022
🤖 I have created a release *beep* *boop* --- ## [0.124.2](googleapis/java-errorreporting@v0.124.1...v0.124.2) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#905](googleapis/java-errorreporting#905)) ([41c601e](googleapis/java-errorreporting@41c601e)) * update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#907](googleapis/java-errorreporting#907)) ([320678e](googleapis/java-errorreporting@320678e)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#908](googleapis/java-errorreporting#908)) ([9a2dbe4](googleapis/java-errorreporting@9a2dbe4)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#911](googleapis/java-errorreporting#911)) ([cb40a3c](googleapis/java-errorreporting@cb40a3c)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#912](googleapis/java-errorreporting#912)) ([014c105](googleapis/java-errorreporting@014c105)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#913](googleapis/java-errorreporting#913)) ([f6fc303](googleapis/java-errorreporting@f6fc303)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#909](googleapis/java-errorreporting#909)) ([ea3ac29](googleapis/java-errorreporting@ea3ac29)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
…913) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.7` -> `2.8.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/compatibility-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/confidence-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.8`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;288-httpsgithubcomgoogleapisjava-corecomparev287v288-2022-08-04) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.7...v2.8.8) ##### Dependencies - update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#&#8203;897](https://togithub.com/googleapis/java-core/issues/897)) ([29e4fc9](https://togithub.com/googleapis/java-core/commit/29e4fc93d5d4d50f7de85eae7a8150314cca6f43)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-errorreporting). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
minherz pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ## [0.124.2](googleapis/java-errorreporting@v0.124.1...v0.124.2) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#905](googleapis/java-errorreporting#905)) ([41c601e](googleapis/java-errorreporting@41c601e)) * update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#907](googleapis/java-errorreporting#907)) ([320678e](googleapis/java-errorreporting@320678e)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#908](googleapis/java-errorreporting#908)) ([9a2dbe4](googleapis/java-errorreporting@9a2dbe4)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#911](googleapis/java-errorreporting#911)) ([cb40a3c](googleapis/java-errorreporting@cb40a3c)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#912](googleapis/java-errorreporting#912)) ([014c105](googleapis/java-errorreporting@014c105)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#913](googleapis/java-errorreporting#913)) ([f6fc303](googleapis/java-errorreporting@f6fc303)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#909](googleapis/java-errorreporting#909)) ([ea3ac29](googleapis/java-errorreporting@ea3ac29)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
…913) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.7` -> `2.8.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/compatibility-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/confidence-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.8`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;288-httpsgithubcomgoogleapisjava-corecomparev287v288-2022-08-04) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.7...v2.8.8) ##### Dependencies - update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#&#8203;897](https://togithub.com/googleapis/java-core/issues/897)) ([29e4fc9](https://togithub.com/googleapis/java-core/commit/29e4fc93d5d4d50f7de85eae7a8150314cca6f43)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-errorreporting). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
minherz pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ## [0.124.2](googleapis/java-errorreporting@v0.124.1...v0.124.2) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#905](googleapis/java-errorreporting#905)) ([41c601e](googleapis/java-errorreporting@41c601e)) * update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#907](googleapis/java-errorreporting#907)) ([320678e](googleapis/java-errorreporting@320678e)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#908](googleapis/java-errorreporting#908)) ([9a2dbe4](googleapis/java-errorreporting@9a2dbe4)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#911](googleapis/java-errorreporting#911)) ([cb40a3c](googleapis/java-errorreporting@cb40a3c)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#912](googleapis/java-errorreporting#912)) ([014c105](googleapis/java-errorreporting@014c105)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#913](googleapis/java-errorreporting#913)) ([f6fc303](googleapis/java-errorreporting@f6fc303)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#909](googleapis/java-errorreporting#909)) ([ea3ac29](googleapis/java-errorreporting@ea3ac29)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
…-ai to v2.7.4 (#913) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-document-ai](https://togithub.com/googleapis/java-document-ai) | `2.7.3` -> `2.7.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.7.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.7.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.7.4/compatibility-slim/2.7.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.7.4/confidence-slim/2.7.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNi4wIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
…-ai to v2.7.4 (#913) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-document-ai](https://togithub.com/googleapis/java-document-ai) | `2.7.3` -> `2.7.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.7.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.7.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.7.4/compatibility-slim/2.7.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.7.4/confidence-slim/2.7.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNi4wIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

5 participants