Exclude generated code files from code coverage. #198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was causing the Coveralls plugin to fail with "Source not found".
| @lesv One more change to coverage plugin. I was able to manually run the plugin. Hopefully this means we'll get a coverage report after Travis finishes. I'm thinking we should reconsider how we handle protocol buffers, since this will be a pain to maintain, and I'm afraid we might exclude more than we mean to. |
| Ugh. Coveralls had another error when running on Travis. I'll look into this. |
| "My guess is that you have multi-module project containing duplicate package/class names" We probably do this. I think I use the |
| I'll close this for now. Hopefully codecov works better. #199 |
minherz pushed a commit that referenced this pull request Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [0.120.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.120.0...v0.120.1) (2020-08-10) ### Bug Fixes * **v1beta1:** migrate to grpc_service_config ([#195](https://www.github.com/googleapis/java-errorreporting/issues/195)) ([3a2ddcf](https://www.github.com/googleapis/java-errorreporting/commit/3a2ddcfb8da2f376be800c62b32f96b271d9f1d2)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#189](https://www.github.com/googleapis/java-errorreporting/issues/189)) ([fb6dbc7](https://www.github.com/googleapis/java-errorreporting/commit/fb6dbc7633397761772d812fa9f55923ea0ca006)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#193](https://www.github.com/googleapis/java-errorreporting/issues/193)) ([cdbb26b](https://www.github.com/googleapis/java-errorreporting/commit/cdbb26b95b4e9d90d664c91210512c70d112acde)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#198](https://www.github.com/googleapis/java-errorreporting/issues/198)) ([0d29ee2](https://www.github.com/googleapis/java-errorreporting/commit/0d29ee2023c45a49a08d0c8b08e1571137500cd1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [0.120.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.120.0...v0.120.1) (2020-08-10) ### Bug Fixes * **v1beta1:** migrate to grpc_service_config ([#195](https://www.github.com/googleapis/java-errorreporting/issues/195)) ([3a2ddcf](https://www.github.com/googleapis/java-errorreporting/commit/3a2ddcfb8da2f376be800c62b32f96b271d9f1d2)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#189](https://www.github.com/googleapis/java-errorreporting/issues/189)) ([fb6dbc7](https://www.github.com/googleapis/java-errorreporting/commit/fb6dbc7633397761772d812fa9f55923ea0ca006)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#193](https://www.github.com/googleapis/java-errorreporting/issues/193)) ([cdbb26b](https://www.github.com/googleapis/java-errorreporting/commit/cdbb26b95b4e9d90d664c91210512c70d112acde)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#198](https://www.github.com/googleapis/java-errorreporting/issues/198)) ([0d29ee2](https://www.github.com/googleapis/java-errorreporting/commit/0d29ee2023c45a49a08d0c8b08e1571137500cd1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [0.120.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.120.0...v0.120.1) (2020-08-10) ### Bug Fixes * **v1beta1:** migrate to grpc_service_config ([#195](https://www.github.com/googleapis/java-errorreporting/issues/195)) ([3a2ddcf](https://www.github.com/googleapis/java-errorreporting/commit/3a2ddcfb8da2f376be800c62b32f96b271d9f1d2)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#189](https://www.github.com/googleapis/java-errorreporting/issues/189)) ([fb6dbc7](https://www.github.com/googleapis/java-errorreporting/commit/fb6dbc7633397761772d812fa9f55923ea0ca006)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#193](https://www.github.com/googleapis/java-errorreporting/issues/193)) ([cdbb26b](https://www.github.com/googleapis/java-errorreporting/commit/cdbb26b95b4e9d90d664c91210512c70d112acde)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#198](https://www.github.com/googleapis/java-errorreporting/issues/198)) ([0d29ee2](https://www.github.com/googleapis/java-errorreporting/commit/0d29ee2023c45a49a08d0c8b08e1571137500cd1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
charlieyu1996 pushed a commit that referenced this pull request Nov 10, 2022
….1 (#198) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | patch | `7.0.0` -> `7.0.1` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-talent).
This was referenced Nov 10, 2022
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
….0 (#198) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `5.4.0` -> `5.5.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-dataproc).
9 tasks
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was causing the Coveralls plugin to fail with "Source not found".