Skip to content

fix(retail): add region tag for Java - Update Search with query expansion spec #10112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 16, 2025
Merged

fix(retail): add region tag for Java - Update Search with query expansion spec #10112

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b60adfb
Update SearchWithPagination.java
rebeccaellis Jun 11, 2025
24e9ac1
Merge pull request #2 from rebeccaellis/rebeccaellis-patch-search-wit…
rebeccaellis Jun 11, 2025
009b2e2
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 13, 2025
8a99d05
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 17, 2025
50ac4d1
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 27, 2025
645c9f4
Update SearchWithQueryExpansionSpec.java
rebeccaellis Jun 27, 2025
c396944
Update SearchWithQueryExpansionSpec.java
rebeccaellis Jun 28, 2025
b87b12c
Update SearchWithQueryExpansionSpec.java
rebeccaellis Jul 7, 2025
ee2c6e0
Merge branch 'main' into rebeccaellis-search-with-query-expansion
glasnt Jul 16, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion retail/interactive-tutorials/src/main/java/search/SearchWithQueryExpansionSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*/

package search;

// [START retail_search_for_products_with_query_expansion_specification]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other samples in this repository (e.g., SearchSimpleQuery.java) and to improve readability, please add a blank line before and after the START region tag. This separates the package declaration, sample tag, and import statements.

The desired format is:

package search; // [START retail_search_for_products_with_query_expansion_specification] import com.google.cloud.ServiceOptions;
import com.google.cloud.ServiceOptions;
import com.google.cloud.retail.v2.SearchRequest;
import com.google.cloud.retail.v2.SearchRequest.QueryExpansionSpec;
Expand Down Expand Up @@ -76,3 +76,4 @@ public static void searchResponse(String defaultSearchPlacementName) throws IOEx
}
}
}
// [END retail_search_for_products_with_query_expansion_specification]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability, please add a blank line before this END region tag. This helps to visually separate the code from the sample metadata tags.

For example:

 } } // [END retail_search_for_products_with_query_expansion_specification]