Bug fixes for cloud event conversion #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit fixes a few bugs in the code that converts legacy events to cloud events: - preserve nulls when serializing JSON - firebaseauth and firebasedatabase event types - firebaseauth subject is derived form user ID in event data - fix code to extract firebasedatabase subject from resourceName
eamonnmcmanus requested changes Mar 23, 2021
invoker/core/src/test/java/com/google/cloud/functions/invoker/GcfEventsTest.java Outdated Show resolved Hide resolved
mtraver reviewed Mar 23, 2021
| @eamonnmcmanus is this good to land now? |
eamonnmcmanus approved these changes Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit fixes a few bugs in the code that converts legacy events to
cloud events: