- Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(genai): add image generation samples (1) #3276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add image generation samples (1) #3276
Conversation
| Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the GenAI SDK samples by adding new C# examples for image generation. These samples cover various scenarios, including basic text-to-image generation, locale-aware image generation, and the ability to generate multiple images from a single prompt, providing comprehensive demonstrations of the SDK's image generation features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new samples for image generation with GenAI, including tests. The code is clear and effectively demonstrates the intended features. I've provided a few suggestions to improve naming consistency, fix typos in code region tags, and enhance the robustness of filename generation in the multiple-image sample.
genai/api/GenAI.Samples.Tests/ImageGeneration/ImgGenMmFlashMultipleImgsWithTxtTest.cs Outdated Show resolved Hide resolved
genai/api/GenAI.Samples/ImageGeneration/ImgGenMmFlashMultipleImgsWithTxt.cs Outdated Show resolved Hide resolved
genai/api/GenAI.Samples/ImageGeneration/ImgGenMmFlashMultipleImgsWithTxt.cs Show resolved Hide resolved
genai/api/GenAI.Samples/ImageGeneration/ImgGenMmFlashMultipleImgsWithTxt.cs Outdated Show resolved Hide resolved
matthew29tang left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, left one minor question about a code sample name
| * limitations under the License. | ||
| */ | ||
| | ||
| // [START googlegenaisdk_imggen_mmflash_locale_aware_with_txt] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why this sample is called locale aware?
| using System.IO; | ||
| using System.Threading.Tasks; | ||
| | ||
| public class ImgGenMmFlashLocaleAwareWithTxt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this should have a clearer name. Specifically, the Mm part does not reflect that.
| string projectId = "your-project-id", | ||
| string location = "global", | ||
| string model = "gemini-2.5-flash-image") | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the samples have a try-catch to catch the errors. I think that we should aim for that here as well just to 1. showcase some simple error handling, and 2. keep consistency with other languages that have a try-catch as well.
Add new samples for image generation:
All local tests have passed