Skip to content

[bugfix] added a conditional to check if navigator is defined #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

[bugfix] added a conditional to check if navigator is defined #42

merged 1 commit into from
Dec 9, 2019

Conversation

@anton-karlovskiy
Copy link
Contributor

@anton-karlovskiy anton-karlovskiy commented Dec 9, 2019

@addyosmani

When server side rendering, navigator is not defined.
navigator-undefined
addyosmani
addyosmani approved these changes Dec 9, 2019
View reviewed changes
Copy link
Collaborator

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@addyosmani addyosmani merged commit 245c389 into GoogleChromeLabs:master Dec 9, 2019
@anton-karlovskiy anton-karlovskiy deleted the bugfix/check-navigator branch December 9, 2019 22:09
@theZieger theZieger mentioned this pull request Dec 10, 2019
Closed
@anton-karlovskiy anton-karlovskiy changed the title added a conditional to check if navigator is defined [bugfix] added a conditional to check if navigator is defined Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@anton-karlovskiy @addyosmani