- Notifications
You must be signed in to change notification settings - Fork 4k
Refactor getContentPointer usage into getSiteContentPointer #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| The latest updates on your projects. Learn more about Argos notifications ↗︎
|
SamyPesse left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, we should monitor it when we deploy and test all routes.
This PR splits
app/(space)intoapp/(site)andapp/(space)/~gitbook/pdfapp/(site)will ALWAYS usegetSiteContentPointerapp/(space)/~gitbook/pdfsupports both pointers (special case)Next PR:
getSpaceCustomizationshould return the default customization object instead of making an API calllistSpaceIntegrationScriptsshould return[]instead of making an API call