Skip to content

Conversation

@taranvohra
Copy link
Member

@taranvohra taranvohra commented Oct 14, 2024

This PR splits app/(space) into app/(site) and app/(space)/~gitbook/pdf

  • app/(site) will ALWAYS use getSiteContentPointer
  • app/(space)/~gitbook/pdf supports both pointers (special case)

Next PR:

  • getSpaceCustomization should return the default customization object instead of making an API call
  • listSpaceIntegrationScripts should return [] instead of making an API call
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 284b488

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 14, 2024 05:05 Inactive
@argos-ci
Copy link

argos-ci bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 14 changed Oct 14, 2024, 6:35 AM
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 14, 2024 05:17 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 14, 2024 05:17 Inactive
@taranvohra taranvohra requested a review from SamyPesse October 14, 2024 05:33
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 14, 2024 05:35 Inactive
@taranvohra taranvohra marked this pull request as ready for review October 14, 2024 05:36
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, we should monitor it when we deploy and test all routes.

@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) October 14, 2024 06:31 Inactive
@taranvohra taranvohra merged commit 79f2d8b into main Oct 14, 2024
9 checks passed
@taranvohra taranvohra deleted the split-app-space-site branch October 14, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants