Tree shake unused code for Sentry #2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Noticed that one of the JS chunks for the app was quite big, and it included a whole lot of code dedicated to Sentry only, which we don't use to a lot of extent client-side (no integrations).
Searched and found this GitHub issue, talking about this tree shaking guide.
Applying the suggestions led to removing ~40KB of gzipped code, or ~136KB of uncompressed JS, which is ~10% of the first load JS code size.
Before (main)
After