Skip to content

Fix fullPage screenshots #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix fullPage screenshots #2230

merged 1 commit into from
Mar 25, 2024

Conversation

@gregberge
Copy link
Contributor

@gregberge gregberge commented Mar 25, 2024

No description provided.

@linear
Copy link

linear bot commented Mar 25, 2024

RND-3320 Why was the full-page disabled in the tests?
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) March 25, 2024 10:30 Inactive
SamyPesse
SamyPesse reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this last week and I finally think it's better to default to false and set it to true on case by case basis.
@gregberge gregberge force-pushed the greg/rnd-3320-why-was-the-full-page-disabled-in-the-tests branch from 0408a25 to 5ce262b Compare March 25, 2024 10:46
@gregberge gregberge force-pushed the greg/rnd-3320-why-was-the-full-page-disabled-in-the-tests branch from 5ce262b to 78da909 Compare March 25, 2024 10:47
@gregberge
Copy link
Contributor Author

gregberge commented Mar 25, 2024

I've tested this last week and I finally think it's better to default to false and set it to true on case by case basis.

OK, I changed it then.
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) March 25, 2024 10:49 Inactive
@github-actions github-actions bot temporarily deployed to gitbook-open (Preview) March 25, 2024 10:50 Inactive
@gregberge gregberge merged commit 4c286b5 into main Mar 25, 2024
@gregberge gregberge deleted the greg/rnd-3320-why-was-the-full-page-disabled-in-the-tests branch March 25, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@gregberge @SamyPesse