Fix: updateAudioTrackUsage not storing the audioUsage if called before audioTrack creation #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This uses the PayloadTypeSuggester for PT disambiguation, ensuring that conficts are managed across the transport. Bug: webrtc:360058654 Change-Id: Ic8f0569d0d96d97c13765169903929ec8a110104 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383400 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Evan Shrubsole <eshr@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44284}
This reverts commit c92fc76. Reason for revert: Gerritt submitted patch set #10 not #12 - this broke Original change's description: > Assign supported codecs per section, not globally. > > This uses the PayloadTypeSuggester for PT disambiguation, > ensuring that conficts are managed across the transport. > > Bug: webrtc:360058654 > Change-Id: Ic8f0569d0d96d97c13765169903929ec8a110104 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383400 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Evan Shrubsole <eshr@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#44284} Bug: webrtc:360058654 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I16d0d92fb9a1ecc65eda060f81d41faefcca1e4c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384000 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44285}
Before we are "ready to send", there is a short period of time where substream stats are not present and this method returns early. This code path must also remember to set encodingIndex for the one and only outbound-rtp stats object that gets created as a result. Tested: - Necessary to pass WPTs added in https://chromium-review.googlesource.com/c/chromium/src/+/6425421 Bug: chromium:406922375 Change-Id: I05e2e55eac0cc2744987d12dfe9c9c1e4e0e2034 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383901 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44286}
Change log: https://chromium.googlesource.com/chromium/src/+log/c87b2ac78e..080be11409 Full diff: https://chromium.googlesource.com/chromium/src/+/c87b2ac78e..080be11409 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/e62aa1e0a8..f2ba5fd49b * src/build: https://chromium.googlesource.com/chromium/src/build/+log/7f64565e57..56ec42ee91 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/299cb62c60..4b3b2242db * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/a049c89748..f58634676e * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/66a91bf619..60d01c1030 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/ee428b2cc3..4f26618a64 * src/third_party/breakpad/breakpad: https://chromium.googlesource.com/breakpad/breakpad.git/+log/657a441e5c..884742b238 * src/third_party/fuzztest/src: https://chromium.googlesource.com/external/github.com/google/fuzztest.git/+log/998cda318c..33bb3d2040 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/c8811240b9..71d303d18f * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/35a5aaad4a..723abbda20 * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/23bef80461..4b760d9a76 * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/1b9b9ace3d..a4368045f0 * src/tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90 * src/tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90 * src/tools/luci-go: git_revision:7a44078a668bc9f75dd6e40a332450e76f2f7399..git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90 DEPS diff: https://chromium.googlesource.com/chromium/src/+/c87b2ac78e..080be11409/DEPS No update to Clang. BUG=None Change-Id: Ied31df2989a13521d064a84bdeabe24b212120a7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383962 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44287}
This reverts commit 374b892. Reason for revert: Racing CLs sorted out Original change's description: > Revert "Assign supported codecs per section, not globally." > > This reverts commit c92fc76. > > Reason for revert: Gerritt submitted patch set #10 not #12 - this broke > > Original change's description: > > Assign supported codecs per section, not globally. > > > > This uses the PayloadTypeSuggester for PT disambiguation, > > ensuring that conficts are managed across the transport. > > > > Bug: webrtc:360058654 > > Change-Id: Ic8f0569d0d96d97c13765169903929ec8a110104 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383400 > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Evan Shrubsole <eshr@webrtc.org> > > Reviewed-by: Henrik Boström <hbos@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#44284} > > Bug: webrtc:360058654 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I16d0d92fb9a1ecc65eda060f81d41faefcca1e4c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384000 > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#44285} Bug: webrtc:360058654 Change-Id: I80b59aab396abbc0afa60dab3516f2a22e822a5d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383981 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44288}
Change log: https://chromium.googlesource.com/chromium/src/+log/080be11409..479c058ca2 Full diff: https://chromium.googlesource.com/chromium/src/+/080be11409..479c058ca2 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/f2ba5fd49b..b0ecf00319 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/56ec42ee91..2950487dcd * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/f58634676e..9b26cef2c0 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/60d01c1030..31101839b3 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/4f26618a64..61b45617a8 * src/third_party/android_deps/autorolled/cipd: -kw2ioUuVwgaTHjBYvcyYBT3SZ24bRuwH_rIhsiZ24IC..TFiDa5VbziMUligPbDLeDXpPmLBgBdhqIj5CslOiRLMC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/c86127e656..f0ab91129d * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/71d303d18f..2b149599d9 * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/a4368045f0..252128f6c3 * src/tools/luci-go: git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf * src/tools/luci-go: git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf * src/tools/luci-go: git_revision:eef34c694bdab861ded59a7e34ddf4d97e013c90..git_revision:cd0142e4e2f376bb0bd1b34a3b91167aff5226bf DEPS diff: https://chromium.googlesource.com/chromium/src/+/080be11409..479c058ca2/DEPS No update to Clang. BUG=None Change-Id: I45a6a1c3a82f42257a97a996e1f5bd8cf5a401e2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384020 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44289}
Bug: None Change-Id: I2672842051e85a0e62b1f5d837832caf60750664 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384040 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44290}
This would ensure fields trials are always provided and thus Port will be able to remove fallback to the global field trials. Bug: webrtc:405883462 Change-Id: I18c1ede4324a86078477be42d38abcf6f2a53361 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383801 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44291}
Change log: https://chromium.googlesource.com/chromium/src/+log/479c058ca2..f2812e793c Full diff: https://chromium.googlesource.com/chromium/src/+/479c058ca2..f2812e793c Changed dependencies * fuchsia_version: version:27.20250326.5.1..version:27.20250402.5.1 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/2950487dcd..26ff83f048 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/31101839b3..576e7554b9 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/61b45617a8..c22170aab3 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/2b149599d9..4eacaf78be * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-5118-g52cd27e6.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/252128f6c3..a3c5fe0e54 DEPS diff: https://chromium.googlesource.com/chromium/src/+/479c058ca2..f2812e793c/DEPS No update to Clang. BUG=None Change-Id: I78ffec8bb9aad0407e210ef299212195f722f3d6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384061 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44292}
Bug: None Change-Id: I6fd76786d040c1c591ce4c7d437ec634c2f09271 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383920 Commit-Queue: Evan Shrubsole <eshr@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Evan Shrubsole <eshr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44293}
Change log: https://chromium.googlesource.com/chromium/src/+log/f2812e793c..c6ae2d7757 Full diff: https://chromium.googlesource.com/chromium/src/+/f2812e793c..c6ae2d7757 Changed dependencies * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/9b26cef2c0..579ee5ef12 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/576e7554b9..3854c0d55c * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/c22170aab3..e85daf0384 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8010a1b2f5..7236fd6c03 * src/third_party/harfbuzz-ng/src: https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/8efd2d85c7..9f83bbbe64 * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/a3c5fe0e54..30615716ef DEPS diff: https://chromium.googlesource.com/chromium/src/+/f2812e793c..c6ae2d7757/DEPS Clang version changed llvmorg-21-init-5118-g52cd27e6:llvmorg-21-init-6681-g5b36835d Details: https://chromium.googlesource.com/chromium/src/+/f2812e793c..c6ae2d7757/tools/clang/scripts/update.py BUG=None Change-Id: I0fb77f183dd0a426f0ef68b06c1ba4dbbb1464ae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384063 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44294}
We're moving all references to exec_script_whitelist in GN to use exec_script_allowlist instead. Bug: chromium:389986807 Change-Id: Ie354a267b98072b83d8df30a5d6cb78496960d29 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383965 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#44295}
The test_case_name is based on the flag isolated_script_test_perf_output instead which is only set when uploading the metrics to CPD. Change-Id: Ic8a92c548a2683ab5083eedb5e6b159aa072db2e Bug: webrtc:42225051 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384081 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44296}
Bug: b:402019802 Change-Id: I15ff3cbaae84e0c7d40f452fd105dd3efab0b5be Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384140 Commit-Queue: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44297}
This will be used to compare new implementations of Base64 (abseil and Rust). Current on my machine results look like. ❯ out/Release/base64_benchmark --------------------------------------------------------------------------- Benchmark Time CPU Iterations --------------------------------------------------------------------------- BM_Base64Encode/64 123 ns 123 ns 5689290 BM_Base64Encode/512 750 ns 750 ns 941209 BM_Base64Encode/4096 5973 ns 5972 ns 122699 BM_Base64Encode/32768 45960 ns 45944 ns 14989 BM_Base64Encode/262144 372323 ns 372158 ns 1899 BM_Base64Encode/2097152 2984810 ns 2983847 ns 237 BM_Base64Encode/8388608 12073887 ns 12067914 ns 58 BM_Base64Decode/64 275 ns 275 ns 2543692 BM_Base64Decode/512 1897 ns 1897 ns 371668 BM_Base64Decode/4096 14875 ns 14871 ns 47373 BM_Base64Decode/32768 118947 ns 118904 ns 5904 BM_Base64Decode/262144 946780 ns 946229 ns 743 BM_Base64Decode/2097152 7587559 ns 7585678 ns 93 BM_Base64Decode/8388608 30476757 ns 30464404 ns 23 BM_Base64DecodeForgiving/64 271 ns 271 ns 2575094 BM_Base64DecodeForgiving/512 1991 ns 1990 ns 350958 BM_Base64DecodeForgiving/4096 15746 ns 15742 ns 44414 BM_Base64DecodeForgiving/32768 125640 ns 125550 ns 5598 BM_Base64DecodeForgiving/262144 1006027 ns 1005577 ns 701 BM_Base64DecodeForgiving/2097152 8041495 ns 8037190 ns 87 BM_Base64DecodeForgiving/8388608 32310820 ns 32292374 ns 22 Bug: webrtc:406686729 Change-Id: I213ff84575352704b87f14ba50802a0617f9ddd9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384101 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Auto-Submit: Evan Shrubsole <eshr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44298}
Bug: webrtc:42225151 Change-Id: I2be14871583a7777ce967aca0454820f5acb6e96 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384180 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44299}
Since abseil/abseil-cpp@03a179c attribute-like annotation are preferred over type-like annotation No-Try: true Bug: webrtc:407433459 Change-Id: Iebe6dd270f9c73aeeafc1d4bda1885d4a72aa5cb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384401 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44300}
absl::Nonnull -> absl_nonnull, absl::Nullable -> absl_nullable, and absl::NullabilityUnknown -> absl_nullability_unknown. The new macros are positioned as a qualifier on the affected type, similar to const, rather than as a templated type wrapping the affected type. Bug: webrtc:407433459 No-Iwyu: No regressions introduced by this CL Change-Id: Id6b1a58296d52c86db3ae44e90849affc904d335 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384220 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44301}
Bug: webrtc:405883462 Change-Id: I7208dcaf40b3c7b3ebc5789967c276c32218714e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384100 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44302}
Bug: webrtc:405883462 Change-Id: Ie010ee7dafd6ba2e5275df0b3dd4a6cb10054fae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384120 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44303}
Bug: None Change-Id: I2f602ec2529d9758b571738831b2445805d8ab8c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384660 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44304}
Change log: https://chromium.googlesource.com/chromium/src/+log/c6ae2d7757..0162baed13 Full diff: https://chromium.googlesource.com/chromium/src/+/c6ae2d7757..0162baed13 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/b0ecf00319..f6e6496f37 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/26ff83f048..8f9146542d * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/579ee5ef12..1ae05801a5 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/3854c0d55c..f502728f35 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/e85daf0384..cf40319a99 * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/f0ab91129d..a553a9d65a * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7236fd6c03..6e0dcdccb3 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/29152c0585..ca270042d1 * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/30615716ef..e8903c6d70 DEPS diff: https://chromium.googlesource.com/chromium/src/+/c6ae2d7757..0162baed13/DEPS No update to Clang. BUG=None Change-Id: I5bd4a3e98b41c1e5642e376dd5babfd081d7cc79 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384200 Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44305}
Change-Id: Ifc81aafd0182ca299bd649eef01c360d516c93c0 Bug: webrtc:42225051 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384360 Commit-Queue: Jeremy Leconte <jleconte@webrtc.org> Reviewed-by: Manashi Sarkar <manashi@google.com> Cr-Commit-Position: refs/heads/main@{#44306}
Change log: https://chromium.googlesource.com/chromium/src/+log/0162baed13..edf3a2684c Full diff: https://chromium.googlesource.com/chromium/src/+/0162baed13..edf3a2684c Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/f6e6496f37..1cd6068049 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/8f9146542d..38290a4010 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/4b3b2242db..917f0828b3 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/1ae05801a5..48ae12a06c * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/f502728f35..df390a2691 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/cf40319a99..a112a20fec * src/third_party/android_build_tools/manifest_merger/cipd: CsU9U9KptiCc6Y9kUTfQfM4CWrRw4W_SxhOt6SNdf7MC..vHfVYpJ8u72iZgoN6s-BvRweZgVkKP-j_QbT8eSgc3gC * src/third_party/android_deps/autorolled/cipd: TFiDa5VbziMUligPbDLeDXpPmLBgBdhqIj5CslOiRLMC..XMJzgYMtMJpi77Cx7TW3ztVmBVgv-SHdCPJ1AXexJKgC * src/third_party/androidx/cipd: Kb6Mt4bV5tZJ1VC8FHtfDaC3bwHfmdUovz5JfHFzVHgC..brlEP-hD-L2HXCYuK64xAWpsFLigTrCr63IEUJFguisC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/a553a9d65a..d5440dd2c2 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6e0dcdccb3..c8d1e18466 * src/third_party/fuzztest/src: https://chromium.googlesource.com/external/github.com/google/fuzztest.git/+log/33bb3d2040..e98f567d3e * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/4eacaf78be..ac90ebd310 * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/723abbda20..93ee954f85 * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/4b760d9a76..5c22cb8a88 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/ca270042d1..4df384ab8f * src/third_party/r8/cipd: lg4ep5S4K6V2zni9jgt42ga6U-8AR6aAWNSqbe2VdmoC..zwFzxlsxS07IH4Ed1SfJTUKKoelP1ZliLtFWZqW0OioC * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/e8903c6d70..a5bb6ec3e5 DEPS diff: https://chromium.googlesource.com/chromium/src/+/0162baed13..edf3a2684c/DEPS No update to Clang. BUG=None Change-Id: Ic58e337d333025827bb4a26f1180dbc6a0a3a33a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384800 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44307}
Bug: None Change-Id: I7e54eb45b2c653d6736a83e27bf57c6e85941128 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384921 Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44308}
Change log: https://chromium.googlesource.com/chromium/src/+log/edf3a2684c..9e9aaddc4a Full diff: https://chromium.googlesource.com/chromium/src/+/edf3a2684c..9e9aaddc4a Changed dependencies * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/917f0828b3..12130e5ca8 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/48ae12a06c..ae2039a32f * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/a112a20fec..de965d2a6f * src/third_party/androidx/cipd: brlEP-hD-L2HXCYuK64xAWpsFLigTrCr63IEUJFguisC..xv1qMAKVg_fNlJdSb6OINhAiUA5lytGh80P-Z2Qdy7cC * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/93ee954f85..c66de5889c * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/5c22cb8a88..aa5c758d87 * src/third_party/rust-toolchain_version: Linux_x64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Mac_arm64/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz,Win/rust-toolchain-9fcc9cf4a202aadfe1f44722b39c83536eba3dba-2-llvmorg-21-init-1655-g7b473dfe.tar.xz..Linux_x64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Mac_arm64/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz,Win/rust-toolchain-f7b43542838f0a4a6cfdb17fbeadf45002042a77-1-llvmorg-21-init-6681-g5b36835d.tar.xz * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/a5bb6ec3e5..f8acae5510 DEPS diff: https://chromium.googlesource.com/chromium/src/+/edf3a2684c..9e9aaddc4a/DEPS No update to Clang. BUG=None Change-Id: I733c6e321e1dafe4c8e4dfb554cbd892b5bb9216 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/385001 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44309}
Changes: 1. Moving audio_is_initialized_ = true/false to InitPlayOrRecord and ShutdownPlayOrRecord respectively, for clarity. 2. Checking audio_is_initialized_ when accessed, not just DCHECKing. Bug: webrtc:408364830 Change-Id: Ibd383a2baaa074e5515cc48f50a52738200ebf83 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384440 Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Anders Lilienthal <andersc@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44310}
…ay and video_encoder BUG=webrtc:42226242,webrtc:42234149 Change-Id: Idef006d1d526cfdc1109d62f1243047243dbfbc3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383649 Commit-Queue: Philipp Hancke <phancke@meta.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44311}
Bug: None Change-Id: Ia363cefd43fb631ebe18a53d33b787dedeca61eb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/385040 Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#44312}
- channel.h - channel_interface.h - codec_vendor.h - jsep_transport.h - media_options.h - media_protocol_names.h - rtcp_mux_filter.h - simulcast_description.h - srtp_session.h - mock_voice_media_receive_channel_interface.h - transport_stats.h - typed_codec_vendor.h - used_ids.h Bug: webrtc:42232595 Change-Id: Ib37ba97b40a254fa430facfcde7e921f32b30437 No-Iwyu: LSC Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384461 Auto-Submit: Evan Shrubsole <eshr@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Evan Shrubsole <eshr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#44313}
…/m137.5 # Conflicts: # extensions/android-external-audio-processing/BUILD.gn # sdk/android/BUILD.gn # sdk/objc/components/audio/RTCAudioCustomProcessingAdapter.mm
… audioBuffers of what was recorded
…amespace 'webrtc'
…ert_no_deps entry:
This reverts commit c522445.
…ult of bufferSizeFactor = 1.0 while switching b/w mono and stereo
…safe method initPlayoutThreadSafe which does not have any thread checking logic
…safe method initPlayoutThreadSafe which does not have any thread checking logic
…restarted with the new configuration.
…ioAttribute to be updated.
…io Attribute when it is changed from the app
…yback (#63) * Exposed method in JavaaudioDeviceModule to switch between Stereo and Mono playout * Removed call to native layer to get the bufbufferSizeFactor. Use default of bufferSizeFactor = 1.0 while switching b/w mono and stereo * Make setChannelConfigurationAndUsage thread safe by calling a thread safe method initPlayoutThreadSafe which does not have any thread checking logic * Make setChannelConfigurationAndUsage thread safe by calling a thread safe method initPlayoutThreadSafe which does not have any thread checking logic * If playout is currently active, it will be stopped and automatically restarted with the new configuration. * Remove unnecessary check in WebRtcAudioTrack which was preventing audioAttribute to be updated. * Refactored to change only the usage and contentType of AudioTrack Audio Attribute when it is changed from the app * Avoids unnecessary work when usage hasn't changed -no-op if usage is the same * Removed un-necessary null checks and improved comments
…hat same will be picked up when creating the audioTrack.
…hifi_audio # Conflicts: # sdk/android/src/java/org/webrtc/audio/WebRtcAudioTrack.java
…/m137.5_hifi_audio # Conflicts: # sdk/android/src/java/org/webrtc/audio/WebRtcAudioTrack.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.