[Fix]Improve AudioFilter pipeline #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ipavlidakis added bug 
Generated by 🚫 Danger |
Public Interface- open class StreamAudioFilterProcessingModule: RTCDefaultAudioProcessingModule, AudioProcessingModule, @unchecked Sendable - - public var activeAudioFilter: AudioFilter? - - - public init(config: RTCAudioProcessingConfig? = nil,capturePostProcessingDelegate: AudioFilterCapturePostProcessingModule = StreamAudioFilterCapturePostProcessingModule(),renderPreProcessingDelegate: RTCAudioCustomProcessingDelegate? = nil) - - - override public func apply(_ config: RTCAudioProcessingConfig) - public func setAudioFilter(_ filter: AudioFilter?) - open class StreamAudioFilterCapturePostProcessingModule: NSObject, AudioFilterCapturePostProcessingModule, @unchecked Sendable - - public private var audioFilter: AudioFilter? - public private var sampleRate: Int - public private var channels: Int - - - override public init() - - - open func setAudioFilter(_ audioFilter: AudioFilter?) - open func audioProcessingInitialize(sampleRate sampleRateHz: Int,channels: Int) - open func audioProcessingProcess(audioBuffer: RTCAudioBuffer) - open func audioProcessingRelease() - public protocol AudioFilterCapturePostProcessingModule: RTCAudioCustomProcessingDelegate |
Collaborator
SDK Size
|
martinmitrevski approved these changes Sep 12, 2025
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Rewire AudioProcessing pipeline to provide information around the captured AudioBuffers.
🛠 Implementation
This revision transitions the existing AudioProcessing pipeline a Store structure that allows better control and reporting over AudioFiltering. This revision sets the foundation for the HiFI implementation and the WebRTC migration.
🧪 Manual Testing Notes
☑️ Contributor Checklist